Prevent display going to sleep while taking a screenshot

Prevent display going to sleep while taking a screenshot

On MacOS, GrabViewSnapshot() call would block for the duration of
display/GPU sleep which leads to protocol client to wait and tests
to time out when power saving is engaged. This prevents power saving
while there are pending screenshot requests.

BUG=599776
Committed: https://crrev.com/2d6574bd49f71c153f24f0e78671fbcb481a2aaa
Cr-Commit-Position: refs/heads/master@{#398245}

[caseq, 2016-06-07 03:15:18]

caseq@chromium.org changed reviewers:
+ kbr@chromium.org, pfeldman@chromium.org

[caseq, 2016-06-07 03:15:38]

The CQ bit was checked by caseq@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 03:16:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044783002/1

[Ken Russell (switch to Gerrit), 2016-06-07 03:23:15]

LGTM. Thanks for tracking this behavior down.

It would be ideal to get this in ASAP and see if it addresses the persistent
flakiness of multiple of the GPU tests that have been seen on this machine
configuration.

[commit-bot: I haz the power, 2016-06-07 04:30:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 04:30:57]

Dry run: This issue passed the CQ dry run.

[caseq, 2016-06-07 04:32:05]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2016-06-07 04:32:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044783002/1

[pfeldman, 2016-06-07 04:35:29]

https://codereview.chromium.org/2044783002/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/2044783002/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_impl.cc:1284:
power_save_blocker_.reset(static_cast<PowerSaveBlockerImpl*>(
Going impl for the sake of content/ policy seems artificial here. You could
leave it public, right?

[caseq, 2016-06-07 04:36:07]

The CQ bit was unchecked by caseq@chromium.org

[caseq, 2016-06-07 04:44:00]

On 2016/06/07 04:35:29, pfeldman wrote:
>
https://codereview.chromium.org/2044783002/diff/1/content/browser/renderer_ho...
> File content/browser/renderer_host/render_widget_host_impl.cc (right):
> 
>
https://codereview.chromium.org/2044783002/diff/1/content/browser/renderer_ho...
> content/browser/renderer_host/render_widget_host_impl.cc:1284:
> power_save_blocker_.reset(static_cast<PowerSaveBlockerImpl*>(
> Going impl for the sake of content/ policy seems artificial here. You could
> leave it public, right?

Indeed -- fixed!

[Ken Russell (switch to Gerrit), 2016-06-07 04:46:09]

https://codereview.chromium.org/2044783002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_impl.cc (right):

https://codereview.chromium.org/2044783002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_impl.cc:85: #include
"content/browser/power_save_blocker_impl.h"
public power_save_blocker.h?

[pfeldman, 2016-06-07 04:48:34]

lgtm % kbr's nit.

[caseq, 2016-06-07 05:02:37]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-06-07 05:02:38]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2044783002/#ps40001
(title: "impl -> public")

[commit-bot: I haz the power, 2016-06-07 05:02:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044783002/40001

[commit-bot: I haz the power, 2016-06-07 08:08:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-07 08:09:37]

Description was changed from

==========
Prevent display going to sleep while taking a screenshot

On MacOS, GrabViewSnapshot() call would block for the duration of
display/GPU sleep which leads to protocol client to wait and tests
to time out when power saving is engaged. This prevents power saving
while there are pending screenshot requests.

BUG=599776
==========

to

==========
Prevent display going to sleep while taking a screenshot

On MacOS, GrabViewSnapshot() call would block for the duration of
display/GPU sleep which leads to protocol client to wait and tests
to time out when power saving is engaged. This prevents power saving
while there are pending screenshot requests.

BUG=599776

Committed: https://crrev.com/2d6574bd49f71c153f24f0e78671fbcb481a2aaa
Cr-Commit-Position: refs/heads/master@{#398245}
==========

[commit-bot: I haz the power, 2016-06-07 08:09:39]

Patchset 3 (id:??) landed as
https://crrev.com/2d6574bd49f71c153f24f0e78671fbcb481a2aaa
Cr-Commit-Position: refs/heads/master@{#398245}