Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 2044773002: Merge M52: "Don't reset the codec state for a flush; this kills the frames." (Closed)

Created:
4 years, 6 months ago by DaleCurtis
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Merge M52: "Don't reset the codec state for a flush; this kills the frames." Causing a reset after flush completes will invalidate all the vended frames, don't do this. Instead only reset when a reset should actually occur. Instead, since this reset is required on JellyBean devices, we issue the reset upon receipt of the next Decode() call. This allows the more frequent EOS cases to not trash the last frame on these devices will config changes will work as before. A followup CL will move the texture matrix to the shared state so that we don't accidentally apply the wrong matrix after the reset case. BUG=613608 TEST=no more random blue frames. Review-Url: https://codereview.chromium.org/2000833003 Cr-Commit-Position: refs/heads/master@{#395995} (cherry picked from commit eb4a8d89c1c1c3ed4b74e2afdee7ccd8dd6558bc) Committed: https://chromium.googlesource.com/chromium/src/+/e549f94829a31a5337d8b79d7a73bb13a1cfa910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M media/gpu/android_video_decode_accelerator.h View 1 chunk +5 lines, -0 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 3 chunks +19 lines, -0 lines 0 comments Download
M media/gpu/avda_codec_image.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years, 6 months ago (2016-06-07 01:40:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e549f94829a31a5337d8b79d7a73bb13a1cfa910.

Powered by Google App Engine
This is Rietveld 408576698