runtime/vm/dart_api_impl_test.cc - Issue 2044753002: Make compile-time errors catchable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl_test.cc

Issue 2044753002: Make compile-time errors catchable (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl_test.cc

diff --git a/runtime/vm/dart_api_impl_test.cc b/runtime/vm/dart_api_impl_test.cc

index 5560535b45ad685abf77202e96896d8ead3c6291..04fd8eec7e4f18cac09a0b19ab18722abffee857 100644

--- a/runtime/vm/dart_api_impl_test.cc

+++ b/runtime/vm/dart_api_impl_test.cc

@@ -570,7 +570,6 @@ TEST_CASE(Dart_PropagateError) {

result = Dart_Invoke(lib, NewString("Func1"), 0, NULL);

EXPECT(Dart_IsError(result));

- EXPECT(!Dart_ErrorHasException(result));

EXPECT_SUBSTRING("semicolon expected", Dart_GetError(result));

result = Dart_Invoke(lib, NewString("Func2"), 0, NULL);

@@ -584,7 +583,6 @@ TEST_CASE(Dart_PropagateError) {

result = Dart_Invoke(lib, NewString("Func1"), 0, NULL);

EXPECT(Dart_IsError(result));

- EXPECT(!Dart_ErrorHasException(result));

EXPECT_SUBSTRING("semicolon expected", Dart_GetError(result));

result = Dart_Invoke(lib, NewString("Func2"), 0, NULL);

@@ -598,7 +596,6 @@ TEST_CASE(Dart_PropagateError) {

result = Dart_Invoke(lib, NewString("Func1"), 0, NULL);

EXPECT(Dart_IsError(result));

- EXPECT(!Dart_ErrorHasException(result));

EXPECT_SUBSTRING("semicolon expected", Dart_GetError(result));

result = Dart_Invoke(lib, NewString("Func2"), 0, NULL);

« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/exceptions.h » ('j') | no next file with comments »