Make compile-time errors catchable

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 
 #include "platform/assert.h"
 #include "lib/stacktrace.h"
@@ skipping 166 matching lines @@
                               NULL,
                               Heap::kNew)) {
       ASSERT(malformed_type_error.IsNull());  // Type is a raw Map.
       return instance.raw();
     }
   }
   return Instance::null();
 }
 
 
+static bool IsSyntaxErrorObject(Zone* zone, const Object& obj) {
+  Isolate* I = Thread::Current()->isolate();
+  const Class& error_class =
+      Class::Handle(I->object_store()->syntax_error_class());

[siva, 2016/09/15 18:11:45]

Handle(zone, I->object_store()....
as the zone seems to be passed in as a parameter.

[hausner, 2016/09/15 21:28:28]

Done.

+  ASSERT(!error_class.IsNull());
+  if (obj.GetClassId() == error_class.id()) {
+    return true;
+  }
+  return false;
+}
+
+
 static bool GetNativeStringArgument(NativeArguments* arguments,
                                     int arg_index,
                                     Dart_Handle* str,
                                     void** peer) {
   ASSERT(peer != NULL);
   if (Api::StringGetPeerHelper(arguments, arg_index, peer)) {
     *str = NULL;
     return true;
   }
   Thread* thread = arguments->thread();
@@ skipping 557 matching lines @@
   return Api::ClassId(object) == kApiErrorCid;
 }
 
 
 DART_EXPORT bool Dart_IsUnhandledExceptionError(Dart_Handle object) {
   return Api::ClassId(object) == kUnhandledExceptionCid;
 }
 
 
 DART_EXPORT bool Dart_IsCompilationError(Dart_Handle object) {
+  if (Dart_IsUnhandledExceptionError(object)) {
+    DARTSCOPE(Thread::Current());
+    const UnhandledException& error =
+        UnhandledException::Cast(Object::Handle(Z, Api::UnwrapHandle(object)));
+    const Instance& exc = Instance::Handle(Z, error.exception());
+    return IsSyntaxErrorObject(Z, exc);
+  }
   return Api::ClassId(object) == kLanguageErrorCid;
 }
 
 
 DART_EXPORT bool Dart_IsFatalError(Dart_Handle object) {
   return Api::ClassId(object) == kUnwindErrorCid;
 }
 
 
 DART_EXPORT bool Dart_IsVMRestartRequest(Dart_Handle handle) {
@@ skipping 5810 matching lines @@
 
 DART_EXPORT bool Dart_IsPrecompiledRuntime() {
 #if defined(DART_PRECOMPILED_RUNTIME)
   return true;
 #else
   return false;
 #endif
 }
 
 }  // namespace dart