Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2044673002: Add --packages option to gen_snapshot in order to accept package map files (see https://github.com/… (Closed)

Created:
4 years, 6 months ago by siva
Modified:
4 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add --packages option to gen_snapshot in order to accept package map files (see https://github.com/dart-lang/sdk/issues/26362) BUG=26362 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/53c20930d18119936bf0a855611fc6f5494ff032

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review comments #

Patch Set 3 : address-code-review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 6 chunks +35 lines, -3 lines 0 comments Download
M runtime/tools/create_snapshot_bin.py View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
4 years, 6 months ago (2016-06-06 21:00:29 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/2044673002/diff/1/runtime/bin/gen_snapshot.cc File runtime/bin/gen_snapshot.cc (right): https://chromiumcodereview.appspot.com/2044673002/diff/1/runtime/bin/gen_snapshot.cc#newcode678 runtime/bin/gen_snapshot.cc:678: " --packages=<packages_file> Where to find packages, that is, ...
4 years, 6 months ago (2016-06-06 22:57:30 UTC) #3
siva
https://chromiumcodereview.appspot.com/2044673002/diff/1/runtime/bin/gen_snapshot.cc File runtime/bin/gen_snapshot.cc (right): https://chromiumcodereview.appspot.com/2044673002/diff/1/runtime/bin/gen_snapshot.cc#newcode678 runtime/bin/gen_snapshot.cc:678: " --packages=<packages_file> Where to find packages, that is, \n" ...
4 years, 6 months ago (2016-06-06 23:57:12 UTC) #4
siva
4 years, 6 months ago (2016-06-07 00:12:25 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
53c20930d18119936bf0a855611fc6f5494ff032 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698