git_cl.py - Issue 2044663003: git cl try: clarify where the default set of bots is coming from.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 2044663003: git cl try: clarify where the default set of bots is coming from. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index a08141bbe2967eff217db328b9ce8e9c02c856c2..51800a0c2b90bcf45014dd1fbd55a62e8efaba9f 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -4398,7 +4398,10 @@ def CMDtry(parser, args):

# Skip presubmit builders, because these will fail without LGTM.

masters.setdefault(master, {})[builder] = ['defaulttests']

if masters:

+ print('Loaded default bots from CQ config (%s)' % cq_cfg)

return masters

+ else:

+ print('CQ config exists (%s) but has no try bots listed' % cq_cfg)

Sergiy Byelozyorov 2016/06/07 14:58:14 It's not clear from the message what is used in th

if not options.bot:

parser.error('No default try builder to try, use --bot')

« no previous file with comments | « no previous file | no next file » | no next file with comments »