Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 204463008: Remove all calls to WebMediaPlayerClient::needsWebLayerForVideo() as compositing is always enabled. (Closed)

Created:
6 years, 9 months ago by scherkus (not reviewing)
Modified:
6 years, 9 months ago
Reviewers:
jamesr, qinmin, xhwang
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Remove all calls to WebMediaPlayerClient::needsWebLayerForVideo() as compositing is always enabled. BUG=335345 R=qinmin@chromium.org, xhwang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259002

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M content/renderer/media/android/webmediaplayer_android.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
scherkus (not reviewing)
jamesr: here's an easy one removing those calls qinmin: FYI on android stuff https://codereview.chromium.org/204463008/diff/1/content/renderer/media/android/webmediaplayer_android.cc File ...
6 years, 9 months ago (2014-03-20 17:17:45 UTC) #1
qinmin
lgtm
6 years, 9 months ago (2014-03-20 17:27:02 UTC) #2
scherkus (not reviewing)
xhwang: can you take a look at this? basically the blink-side code always returns true, ...
6 years, 9 months ago (2014-03-21 21:25:05 UTC) #3
xhwang
lgtm
6 years, 9 months ago (2014-03-24 16:52:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/204463008/20001
6 years, 9 months ago (2014-03-24 16:52:39 UTC) #5
scherkus (not reviewing)
6 years, 9 months ago (2014-03-24 20:27:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r259002 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698