Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2044623002: Remove FDE_HDEVICESTATE. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove FDE_HDEVICESTATE. The value returned is always NULL and when passed as a param is never used. Committed: https://pdfium.googlesource.com/pdfium/+/fe433f15d60f92ccde7a928160c2e7cc77dcb8bf

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M xfa/fde/fde_gedevice.h View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/fde/fde_gedevice.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M xfa/fde/fde_render.h View 1 chunk +2 lines, -4 lines 0 comments Download
M xfa/fde/fde_render.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M xfa/fde/tto/fde_textout.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/app/xfa_textlayout.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-06 18:51:14 UTC) #3
Tom Sepez
On 2016/06/06 18:51:14, dsinclair wrote: > PTAL. heh. https://codereview.chromium.org/2037863002/
4 years, 6 months ago (2016-06-06 19:01:00 UTC) #4
Tom Sepez
On 2016/06/06 19:01:00, Tom Sepez wrote: > On 2016/06/06 18:51:14, dsinclair wrote: > > PTAL. ...
4 years, 6 months ago (2016-06-06 19:03:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044623002/20001
4 years, 6 months ago (2016-06-06 19:03:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001) as https://pdfium.googlesource.com/pdfium/+/fe433f15d60f92ccde7a928160c2e7cc77dcb8bf
4 years, 6 months ago (2016-06-06 19:03:35 UTC) #9
dsinclair
4 years, 6 months ago (2016-06-06 19:42:59 UTC) #10
Message was sent while issue was closed. 
On 2016/06/06 19:01:00, Tom Sepez wrote:
> On 2016/06/06 18:51:14, dsinclair wrote:
> > PTAL.
> 
> heh. https://codereview.chromium.org/2037863002/

Doh, sorry about that.

Powered by Google App Engine
This is Rietveld 408576698