Adds unit tests for offline_pages::PrerenderAdapter calling PrerenderManager.

chrome/browser/prerender/prerender_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PRERENDER_PRERENDER_MANAGER_H_
 #define CHROME_BROWSER_PRERENDER_PRERENDER_MANAGER_H_
 
 #include <stdint.h>
 
 #include <list>
@@ skipping 37 matching lines @@
 }
 
 namespace content {
 class WebContents;
 }
 
 namespace gfx {
 class Size;
 }
 
+namespace offline_pages {
+class PrerenderAdapterTest;
+}
+
 namespace prerender {
 
 class PrerenderHandle;
 class PrerenderHistory;
 class PrerenderLocalPredictor;
 
 // PrerenderManager is responsible for initiating and keeping prerendered
 // views of web pages. All methods must be called on the UI thread unless
 // indicated otherwise.
 class PrerenderManager : public base::SupportsWeakPtr<PrerenderManager>,
@@ skipping 319 matching lines @@
   // might have committed an omnibox navigation. This is used to possibly
   // shorten the TTL of the prerendered page.
   void SourceNavigatedAway(PrerenderData* prerender_data);
 
  private:
   friend class ::InstantSearchPrerendererTest;
   friend class PrerenderBrowserTest;
   friend class PrerenderContents;
   friend class PrerenderHandle;
   friend class UnitTestPrerenderManager;
+  friend class offline_pages::PrerenderAdapterTest;

[mmenke, 2016/06/11 00:40:32]

Is this still needed?  If so, I recommend adding BlahForTest[ing] methods
instead.  That gives a more defined API to deal with.  I know nothing else is
doing that, but IMHO, they should be.

[dougarnett, 2016/06/12 16:43:09]

SetPrerenderContentsFactory() is what the test needs access to (possibly all
that the ::InstantSearchPrerendererTest friend above needs too).

Looks like this is only used for browsertest and instantsearch test so options
might be to just make public named as is or make public and revise name to
*ForTest and change the callers. 

[mmenke, 2016/06/13 14:52:59]

Could you please rename it to SetPrerenderContentsFactoryForTest, and make it
public, and update all callers.

If that allows you to remove the friend declaration for
::InstantSearchPrerendererTest (Or anything else), please do so.

 
   class OnCloseWebContentsDeleter;
   struct NavigationRecord;
 
   // Time interval before a new prerender is allowed.
   static const int kMinTimeBetweenPrerendersMs = 500;
 
   // Time window for which we record old navigations, in milliseconds.
   static const int kNavigationRecordWindowMs = 5000;
 
@@ skipping 151 matching lines @@
   // Set of process hosts being prerendered.
   typedef std::set<content::RenderProcessHost*> PrerenderProcessSet;
   PrerenderProcessSet prerender_process_hosts_;
 
   DISALLOW_COPY_AND_ASSIGN(PrerenderManager);
 };
 
 }  // namespace prerender
 
 #endif  // CHROME_BROWSER_PRERENDER_PRERENDER_MANAGER_H_