Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2044593004:
Make MockTextInputClient inherit from ui::DummyTextInputClient. (Closed)
|
Created:
4 years, 6 months ago by karandeepb Modified:
4 years, 6 months ago CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, chrome-apps-syd-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake MockTextInputClient inherit from ui::DummyTextInputClient.
Currently MockTextInputClient implements ui::TextInputClient (a pure virtual
interface) without providing any specialized functionality. This CL makes
MockTextInputClient inherit from ui::DummyTextInputClient to avoid boilerplate
code.
BUG=None
Committed: https://crrev.com/03ef3ec2d484ed70eb6e2a26a5522b9a4a67f599
Cr-Commit-Position: refs/heads/master@{#398492}
Patch Set 1 : #Patch Set 2 : #
Messages
Total messages: 26 (14 generated)
Description was changed from ========== -- BUG= ========== to ========== Make MockTextInputClient inherit from ui::DummyTextInputClient. BUG=None ==========
Patchset #1 (id:1) has been deleted
karandeepb@chromium.org changed reviewers: + haibinlu@chromium.org
PTAL. Thanks.
lgtm
The CQ bit was checked by karandeepb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044593004/40001
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
karandeepb@chromium.org changed reviewers: + wez@chromium.org
PTAL wez@. It seems lgtm is needed from a committer.
tapted@chromium.org changed reviewers: + tapted@chromium.org
Um, lgtm? Pretty sure this still fits with How OWNER-who-is-not-a-committer is meant to work :)
The CQ bit was checked by karandeepb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044593004/40001
The CQ bit was unchecked by wez@chromium.org
Please update the CL description to provide some context for _why_ we want to make this change - looks like it just takes advantage of an existing dummy implementation to avoid some boilerplate? Otherwise LGTM - thanks for the cleanup!
Description was changed from ========== Make MockTextInputClient inherit from ui::DummyTextInputClient. BUG=None ========== to ========== Make MockTextInputClient inherit from ui::DummyTextInputClient. Currently MockTextInputClient implements TextInputClient (a pure virtual interface) without providing any specialized functionality. This CL makes MockTextInputClient inherit from ui::DummyTextInputClient to avoid boilerplate code. BUG=None ==========
On 2016/06/08 06:07:34, Wez wrote: > Please update the CL description to provide some context for _why_ we want to > make this change - looks like it just takes advantage of an existing dummy > implementation to avoid some boilerplate? > > Otherwise LGTM - thanks for the cleanup! Done. Thanks.
Description was changed from ========== Make MockTextInputClient inherit from ui::DummyTextInputClient. Currently MockTextInputClient implements TextInputClient (a pure virtual interface) without providing any specialized functionality. This CL makes MockTextInputClient inherit from ui::DummyTextInputClient to avoid boilerplate code. BUG=None ========== to ========== Make MockTextInputClient inherit from ui::DummyTextInputClient. Currently MockTextInputClient implements ui::TextInputClient (a pure virtual interface) without providing any specialized functionality. This CL makes MockTextInputClient inherit from ui::DummyTextInputClient to avoid boilerplate code. BUG=None ==========
The CQ bit was checked by karandeepb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044593004/40001
Message was sent while issue was closed.
Description was changed from ========== Make MockTextInputClient inherit from ui::DummyTextInputClient. Currently MockTextInputClient implements ui::TextInputClient (a pure virtual interface) without providing any specialized functionality. This CL makes MockTextInputClient inherit from ui::DummyTextInputClient to avoid boilerplate code. BUG=None ========== to ========== Make MockTextInputClient inherit from ui::DummyTextInputClient. Currently MockTextInputClient implements ui::TextInputClient (a pure virtual interface) without providing any specialized functionality. This CL makes MockTextInputClient inherit from ui::DummyTextInputClient to avoid boilerplate code. BUG=None ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Make MockTextInputClient inherit from ui::DummyTextInputClient. Currently MockTextInputClient implements ui::TextInputClient (a pure virtual interface) without providing any specialized functionality. This CL makes MockTextInputClient inherit from ui::DummyTextInputClient to avoid boilerplate code. BUG=None ========== to ========== Make MockTextInputClient inherit from ui::DummyTextInputClient. Currently MockTextInputClient implements ui::TextInputClient (a pure virtual interface) without providing any specialized functionality. This CL makes MockTextInputClient inherit from ui::DummyTextInputClient to avoid boilerplate code. BUG=None Committed: https://crrev.com/03ef3ec2d484ed70eb6e2a26a5522b9a4a67f599 Cr-Commit-Position: refs/heads/master@{#398492} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/03ef3ec2d484ed70eb6e2a26a5522b9a4a67f599 Cr-Commit-Position: refs/heads/master@{#398492} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
