Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2044563002: [DevTools] Added missing inputs for protocol_version action (Closed)

Created:
4 years, 6 months ago by kozy
Modified:
4 years, 6 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Added missing inputs for protocol_version action R=pfeldman@chromium.org Committed: https://crrev.com/c63e9ac82b88a332a0538e783ef0348937797be3 Cr-Commit-Position: refs/heads/master@{#398104}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/inspector/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/inspector.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
kozy
Pavel, please take a look!
4 years, 6 months ago (2016-06-06 17:41:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044563002/1
4 years, 6 months ago (2016-06-06 17:42:29 UTC) #3
pfeldman
lgtm
4 years, 6 months ago (2016-06-06 17:55:57 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-06 19:48:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044563002/1
4 years, 6 months ago (2016-06-06 19:52:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 19:59:13 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 20:00:56 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c63e9ac82b88a332a0538e783ef0348937797be3
Cr-Commit-Position: refs/heads/master@{#398104}

Powered by Google App Engine
This is Rietveld 408576698