Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 204453002: A64: Fix write barrier input in KeyedStoreIC::GenerateSloppyArguments. (Closed)

Created:
6 years, 9 months ago by ulan
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Fix write barrier input in KeyedStoreIC::GenerateSloppyArguments. This fixes flaky crashes in gc-stress bot: > Fatal error in ../src/incremental-marking.cc, line 84 > CHECK(obj->IsHeapObject()) failed BUG=353551 LOG=N TEST=test/mjsunit/regress/regress-353551.js R=m.m.capewell@googlemail.com Committed: https://code.google.com/p/v8/source/detail?r=20098

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Use Lsl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M src/a64/ic-a64.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-353551.js View 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ulan
PTAL
6 years, 9 months ago (2014-03-19 12:05:25 UTC) #1
m.m.capewell
DBC, as Jacob's away. https://codereview.chromium.org/204453002/diff/40001/src/a64/ic-a64.cc File src/a64/ic-a64.cc (right): https://codereview.chromium.org/204453002/diff/40001/src/a64/ic-a64.cc#newcode395 src/a64/ic-a64.cc:395: __ Mov(scratch1, Operand(scratch1, LSL, kPointerSizeLog2)); ...
6 years, 9 months ago (2014-03-19 14:11:43 UTC) #2
ulan
https://codereview.chromium.org/204453002/diff/40001/src/a64/ic-a64.cc File src/a64/ic-a64.cc (right): https://codereview.chromium.org/204453002/diff/40001/src/a64/ic-a64.cc#newcode395 src/a64/ic-a64.cc:395: __ Mov(scratch1, Operand(scratch1, LSL, kPointerSizeLog2)); On 2014/03/19 14:11:44, m.m.capewell ...
6 years, 9 months ago (2014-03-19 14:20:27 UTC) #3
m.m.capewell
lgtm
6 years, 9 months ago (2014-03-19 15:55:40 UTC) #4
ulan
6 years, 9 months ago (2014-03-20 08:33:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r20098 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698