chrome/common/chrome_paths.cc - Issue 2044523003: Revert of 👔 Reland of Move side-loaded test data /sdcard -> /sdcard/gtestdata

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_paths.cc

Issue 2044523003: Revert of 👔 Reland of Move side-loaded test data /sdcard -> /sdcard/gtestdata (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/chrome_paths.cc

diff --git a/chrome/common/chrome_paths.cc b/chrome/common/chrome_paths.cc

index 86499317e4c2028b723a1ff81878c8cea4d7add8..accbe55adfe823f68500e13bc11a36de8af5c2fb 100644

--- a/chrome/common/chrome_paths.cc

+++ b/chrome/common/chrome_paths.cc

@@ -444,7 +444,7 @@

#if defined(OS_ANDROID)

// On Android, our tests don't have permission to write to DIR_MODULE.

// gtest/test_runner.py pushes data to external storage.

- if (!PathService::Get(base::DIR_SOURCE_ROOT, &cur))

+ if (!PathService::Get(base::DIR_ANDROID_EXTERNAL_STORAGE, &cur))

return false;

#else

if (!PathService::Get(base::DIR_MODULE, &cur))

« no previous file with comments | « build/apk_test.gypi ('k') | components/cronet/android/BUILD.gn » ('j') | no next file with comments »