Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/autofill/core/common/form_field_data.cc

Issue 2044503002: Refactor the naming scheme of Deserialize* functions in form_field_data.cc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/common/form_field_data.cc
diff --git a/components/autofill/core/common/form_field_data.cc b/components/autofill/core/common/form_field_data.cc
index dee52c7908cec94f72058b4a34edbf92bb8a70e4..6e26b7f6ccbc3d1a867cbe1bf16370c24a384bad 100644
--- a/components/autofill/core/common/form_field_data.cc
+++ b/components/autofill/core/common/form_field_data.cc
@@ -50,8 +50,8 @@ bool ReadAsInt(base::PickleIterator* iter, T* target_value) {
return true;
}
-bool DeserializeCommonSection1(base::PickleIterator* iter,
- FormFieldData* field_data) {
+bool DeserializeSection1(base::PickleIterator* iter,
+ FormFieldData* field_data) {
return iter->ReadString16(&field_data->label) &&
iter->ReadString16(&field_data->name) &&
iter->ReadString16(&field_data->value) &&
@@ -65,20 +65,20 @@ bool DeserializeCommonSection1(base::PickleIterator* iter,
iter->ReadBool(&field_data->should_autocomplete);
}
-bool DeserializeCommonSection2(base::PickleIterator* iter,
- FormFieldData* field_data) {
+bool DeserializeSection3(base::PickleIterator* iter,
+ FormFieldData* field_data) {
return ReadAsInt(iter, &field_data->text_direction) &&
ReadStringVector(iter, &field_data->option_values) &&
ReadStringVector(iter, &field_data->option_contents);
}
-bool DeserializeVersion2Specific(base::PickleIterator* iter,
- FormFieldData* field_data) {
+bool DeserializeSection2(base::PickleIterator* iter,
+ FormFieldData* field_data) {
return ReadAsInt(iter, &field_data->role);
}
-bool DeserializeVersion3Specific(base::PickleIterator* iter,
- FormFieldData* field_data) {
+bool DeserializeSection4(base::PickleIterator* iter,
+ FormFieldData* field_data) {
return iter->ReadString16(&field_data->placeholder);
}
@@ -188,27 +188,27 @@ bool DeserializeFormFieldData(base::PickleIterator* iter,
switch (version) {
case 1: {
- if (!DeserializeCommonSection1(iter, &temp_form_field_data) ||
- !DeserializeCommonSection2(iter, &temp_form_field_data)) {
+ if (!DeserializeSection1(iter, &temp_form_field_data) ||
+ !DeserializeSection3(iter, &temp_form_field_data)) {
LOG(ERROR) << "Could not deserialize FormFieldData from pickle";
return false;
}
break;
}
case 2: {
- if (!DeserializeCommonSection1(iter, &temp_form_field_data) ||
- !DeserializeVersion2Specific(iter, &temp_form_field_data) ||
- !DeserializeCommonSection2(iter, &temp_form_field_data)) {
+ if (!DeserializeSection1(iter, &temp_form_field_data) ||
+ !DeserializeSection2(iter, &temp_form_field_data) ||
+ !DeserializeSection3(iter, &temp_form_field_data)) {
LOG(ERROR) << "Could not deserialize FormFieldData from pickle";
return false;
}
break;
}
case 3: {
- if (!DeserializeCommonSection1(iter, &temp_form_field_data) ||
- !DeserializeVersion2Specific(iter, &temp_form_field_data) ||
- !DeserializeCommonSection2(iter, &temp_form_field_data) ||
- !DeserializeVersion3Specific(iter, &temp_form_field_data)) {
+ if (!DeserializeSection1(iter, &temp_form_field_data) ||
+ !DeserializeSection2(iter, &temp_form_field_data) ||
+ !DeserializeSection3(iter, &temp_form_field_data) ||
+ !DeserializeSection4(iter, &temp_form_field_data)) {
LOG(ERROR) << "Could not deserialize FormFieldData from pickle";
return false;
}
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698