Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 2044453003: Add missing const to CPDF_Stream::InitStream() (Closed)

Created:
4 years, 6 months ago by Tom Sepez
Modified:
4 years, 6 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add missing const to CPDF_Stream::InitStream() Committed: https://pdfium.googlesource.com/pdfium/+/596fc4c034b70e7826d4781432e4b657921f1abc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_stream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_stream.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan, avoid const cast.
4 years, 6 months ago (2016-06-06 22:46:05 UTC) #2
dsinclair
lgtm
4 years, 6 months ago (2016-06-07 13:41:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044453003/1
4 years, 6 months ago (2016-06-07 13:41:35 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 13:41:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/596fc4c034b70e7826d4781432e4b657921f...

Powered by Google App Engine
This is Rietveld 408576698