Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Side by Side Diff: src/mark-compact.cc

Issue 204443002: Temporarily disable evacuation verification for parallel-concurrently swept pages. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 209 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 while (current < limit) { 220 while (current < limit) {
221 HeapObject* object = HeapObject::FromAddress(current); 221 HeapObject* object = HeapObject::FromAddress(current);
222 object->Iterate(&visitor); 222 object->Iterate(&visitor);
223 current += object->Size(); 223 current += object->Size();
224 } 224 }
225 } 225 }
226 } 226 }
227 227
228 228
229 static void VerifyEvacuation(PagedSpace* space) { 229 static void VerifyEvacuation(PagedSpace* space) {
230 // TODO(hpayer): Bring back VerifyEvacuation for parallel-concurrently
231 // swept pages.
232 if ((FLAG_concurrent_sweeping || FLAG_parallel_sweeping) &&
233 space->was_swept_conservatively()) return;
230 PageIterator it(space); 234 PageIterator it(space);
231 235
232 while (it.has_next()) { 236 while (it.has_next()) {
233 Page* p = it.next(); 237 Page* p = it.next();
234 if (p->IsEvacuationCandidate()) continue; 238 if (p->IsEvacuationCandidate()) continue;
235 VerifyEvacuation(p->area_start(), p->area_end()); 239 VerifyEvacuation(p->area_start(), p->area_end());
236 } 240 }
237 } 241 }
238 242
239 243
(...skipping 4274 matching lines...) Expand 10 before | Expand all | Expand 10 after
4514 while (buffer != NULL) { 4518 while (buffer != NULL) {
4515 SlotsBuffer* next_buffer = buffer->next(); 4519 SlotsBuffer* next_buffer = buffer->next();
4516 DeallocateBuffer(buffer); 4520 DeallocateBuffer(buffer);
4517 buffer = next_buffer; 4521 buffer = next_buffer;
4518 } 4522 }
4519 *buffer_address = NULL; 4523 *buffer_address = NULL;
4520 } 4524 }
4521 4525
4522 4526
4523 } } // namespace v8::internal 4527 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698