Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Unified Diff: scripts/master/master_gen.py

Issue 2044423002: master.tryserver.infra: set path_config=kitchen for remote_run builders (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: presubmit Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « masters/master.tryserver.infra/builders.pyl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/master_gen.py
diff --git a/scripts/master/master_gen.py b/scripts/master/master_gen.py
index f7f89bcc94c08dae0f1774b78799bb1b4ac25556..2dd3ccd3e56701a93ad00b3d9b68eb14bb3c62c6 100644
--- a/scripts/master/master_gen.py
+++ b/scripts/master/master_gen.py
@@ -90,8 +90,6 @@ def _Populate(BuildmasterConfig, builders, active_master_cls):
def _ComputeBuilders(builders, m_annotator, active_master_cls):
actual_builders = []
- default_properties = builders.get('default_properties')
-
def cmp_fn(a, b):
a_cat = builders['builders'][a].get('category')
b_cat = builders['builders'][b].get('category')
@@ -115,11 +113,11 @@ def _ComputeBuilders(builders, m_annotator, active_master_cls):
slavebuilddir = builder_data.get('slavebuilddir',
util.safeTranslate(builder_name))
- if default_properties:
- props = default_properties.copy()
- props.update(builder_data.get('properties', {}))
- else:
- props = builder_data.get('properties')
+ props = {}
+ props.update(builders.get('default_properties', {}).copy())
+ if builder_data.get('use_remote_run'):
+ props.update(builders.get('default_remote_run_properties', {}).copy())
+ props.update(builder_data.get('properties', {}))
if builder_data.get('use_remote_run'):
factory = remote_run_factory.RemoteRunFactory(
« no previous file with comments | « masters/master.tryserver.infra/builders.pyl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698