Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2044403002: 🌽 Split up deferred startup tasks. (Closed)

Created:
4 years, 6 months ago by Peter Wen
Modified:
4 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split up deferred startup tasks. Tasks that depend on the app can take longer in a runnable queue, but the ones that rely on the activity being active need more care. Clarifying which ones actually depend on the activity vs app also gives us more accurate accounting. BUG=614452 Committed: https://crrev.com/67d88a4a54b1985d10fb3865121c0e6a08ec78ec Cr-Commit-Position: refs/heads/master@{#399443}

Patch Set 1 #

Patch Set 2 : Remove one more asynctask. #

Patch Set 3 : Remove unused tasks. #

Patch Set 4 : ) #

Total comments: 2

Patch Set 5 : Fix findbugs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -124 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 8 chunks +7 lines, -90 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 1 2 3 4 6 chunks +126 lines, -34 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Peter Wen
🍅
4 years, 6 months ago (2016-06-08 15:02:51 UTC) #2
agrieve
lgtm https://codereview.chromium.org/2044403002/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2044403002/diff/60001/tools/metrics/histograms/histograms.xml#newcode57966 tools/metrics/histograms/histograms.xml:57966: + the background thread. Only logged on Android. ...
4 years, 6 months ago (2016-06-08 19:02:09 UTC) #3
Peter Wen
+tedchoc@ for chrome/android OWNERS. +asvitkine@ for histogram OWNERS. https://codereview.chromium.org/2044403002/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2044403002/diff/60001/tools/metrics/histograms/histograms.xml#newcode57966 tools/metrics/histograms/histograms.xml:57966: + ...
4 years, 6 months ago (2016-06-09 17:59:00 UTC) #5
Alexei Svitkine (slow)
lgtm
4 years, 6 months ago (2016-06-09 18:04:48 UTC) #6
Ted C
lgtm
4 years, 6 months ago (2016-06-09 23:15:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044403002/80001
4 years, 6 months ago (2016-06-13 12:27:55 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 6 months ago (2016-06-13 13:52:18 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 13:52:19 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 13:53:49 UTC) #14
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/67d88a4a54b1985d10fb3865121c0e6a08ec78ec
Cr-Commit-Position: refs/heads/master@{#399443}

Powered by Google App Engine
This is Rietveld 408576698