🌽 Split up deferred startup tasks.

Split up deferred startup tasks.

Tasks that depend on the app can take longer in a runnable queue, but
the ones that rely on the activity being active need more care.

Clarifying which ones actually depend on the activity vs app also
gives us more accurate accounting.

BUG=614452
Committed: https://crrev.com/67d88a4a54b1985d10fb3865121c0e6a08ec78ec
Cr-Commit-Position: refs/heads/master@{#399443}

[Peter Wen, 2016-06-08 15:02:50]

wnwen@chromium.org changed reviewers:
+ agrieve@chromium.org

[Peter Wen, 2016-06-08 15:02:51]

🍅

[agrieve, 2016-06-08 19:02:09]

lgtm

https://codereview.chromium.org/2044403002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2044403002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:57966: +    the background thread. Only
logged on Android.
Are these on a background thread already? Or is that what you plan to do for a
follow-up? (I thought these all ran on UI thread).

[Peter Wen, 2016-06-09 17:58:59]

wnwen@chromium.org changed reviewers:
+ asvitkine@chromium.org, tedchoc@chromium.org

[Peter Wen, 2016-06-09 17:59:00]

+tedchoc@ for chrome/android OWNERS.
+asvitkine@ for histogram OWNERS.

https://codereview.chromium.org/2044403002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2044403002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:57966: +    the background thread. Only
logged on Android.
On 2016/06/08 19:02:09, agrieve wrote:
> Are these on a background thread already? Or is that what you plan to do for a
> follow-up? (I thought these all ran on UI thread).

Yep, I moved a couple more tasks that weren't dependent on being run on the UI
thread into the existing deferred startup AsyncTask. I'd like to start measuring
how long the long tail is for completing everything in that task. :)

Lots of the existing tasks run on the UI thread and many need to be on the UI
thread.

[Alexei Svitkine (slow), 2016-06-09 18:04:48]

lgtm

[Ted C, 2016-06-09 23:15:53]

lgtm

[Peter Wen, 2016-06-13 12:27:41]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2016-06-13 12:27:41]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2044403002/#ps80001
(title: "Fix findbugs.")

[commit-bot: I haz the power, 2016-06-13 12:27:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044403002/80001

[commit-bot: I haz the power, 2016-06-13 13:52:18]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-13 13:52:19]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 13:53:48]

Description was changed from

==========
Split up deferred startup tasks.

Tasks that depend on the app can take longer in a runnable queue, but
the ones that rely on the activity being active need more care.

Clarifying which ones actually depend on the activity vs app also
gives us more accurate accounting.

BUG=614452
==========

to

==========
Split up deferred startup tasks.

Tasks that depend on the app can take longer in a runnable queue, but
the ones that rely on the activity being active need more care.

Clarifying which ones actually depend on the activity vs app also
gives us more accurate accounting.

BUG=614452

Committed: https://crrev.com/67d88a4a54b1985d10fb3865121c0e6a08ec78ec
Cr-Commit-Position: refs/heads/master@{#399443}
==========

[commit-bot: I haz the power, 2016-06-13 13:53:49]

Patchset 5 (id:??) landed as
https://crrev.com/67d88a4a54b1985d10fb3865121c0e6a08ec78ec
Cr-Commit-Position: refs/heads/master@{#399443}