Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 2044393002: Rebaseline printing/thead-repeats-at-top-of-each-page.html again (Closed)

Created:
4 years, 6 months ago by xidachen
Modified:
4 years, 6 months ago
Reviewers:
jbroman
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebaseline printing/thead-repeats-at-top-of-each-page.html again It seems that after this rebaseline CL: https://codereview.chromium.org/2042583002 This test is still missing its expected test result on Win 10. This CL sends another rebaseline. See failure here for details: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10 BUG=618082 Committed: https://crrev.com/67a46a72b12d0a556cf0ccec546b08be058771ea Cr-Commit-Position: refs/heads/master@{#398545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044393002/1
4 years, 6 months ago (2016-06-08 12:43:29 UTC) #3
xidachen
PTAL
4 years, 6 months ago (2016-06-08 13:10:15 UTC) #6
jbroman
lgtm By the way, it's OK for you to TBR TestExpectations changes as sheriff if ...
4 years, 6 months ago (2016-06-08 13:27:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044393002/1
4 years, 6 months ago (2016-06-08 13:29:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 14:14:36 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 14:17:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67a46a72b12d0a556cf0ccec546b08be058771ea
Cr-Commit-Position: refs/heads/master@{#398545}

Powered by Google App Engine
This is Rietveld 408576698