Use faster case for on tile sampling, and a little clean up

Use faster case for on tile sampling, and a little clean up. This has been a sampling bug and so was bypassed using "false &&". Found the sampling bug and added the case back in.

Remove long commented out code.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044373003

Committed: https://skia.googlesource.com/skia/+/dd40483534f57df206020c174cb56e2b2c258015

[herb_g, 2016-06-08 20:24:52]

Description was changed from

==========
Use faster case for on tile sampling, and a little clean up.

BUG=skia:
==========

to

==========
Use faster case for on tile sampling, and a little clean up.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044373003
==========

[herb_g, 2016-06-08 20:26:33]

Description was changed from

==========
Use faster case for on tile sampling, and a little clean up.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044373003
==========

to

==========
Use faster case for on tile sampling, and a little clean up. This has been a
sampling bug and so was bypassed using "false &&". Found the sampling bug and
added the case back in.

Remove long commented out code.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044373003
==========

[herb_g, 2016-06-08 20:26:34]

herb@google.com changed reviewers:
+ mtklein@google.com

[herb_g, 2016-06-08 20:32:01]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 20:32:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044373003/1

[commit-bot: I haz the power, 2016-06-08 20:50:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 20:50:09]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-06-08 20:58:49]

lgtm

https://codereview.chromium.org/2044373003/diff/1/src/core/SkLinearBitmapPipe...
File src/core/SkLinearBitmapPipeline_sample.h (right):

https://codereview.chromium.org/2044373003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline_sample.h:315: Sk4f bilerNonEdgePixel(SkScalar x,
SkScalar y) {
you can't spell

https://codereview.chromium.org/2044373003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline_sample.h:317: // Offset for filtering is
expected in the top left of the kernel.
// bilerp4() expects xs,ys are the top-lefts of the 2x2 kernel.

?

[herb_g, 2016-06-08 21:04:35]

Address comments.

[herb_g, 2016-06-08 21:05:41]

The CQ bit was checked by herb@google.com

[herb_g, 2016-06-08 21:05:42]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2044373003/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-06-08 21:05:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044373003/20001

[herb_g, 2016-06-08 21:05:48]

https://codereview.chromium.org/2044373003/diff/1/src/core/SkLinearBitmapPipe...
File src/core/SkLinearBitmapPipeline_sample.h (right):

https://codereview.chromium.org/2044373003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline_sample.h:315: Sk4f bilerNonEdgePixel(SkScalar x,
SkScalar y) {
On 2016/06/08 20:58:49, mtklein wrote:
> you can't spell

Fxied

https://codereview.chromium.org/2044373003/diff/1/src/core/SkLinearBitmapPipe...
src/core/SkLinearBitmapPipeline_sample.h:317: // Offset for filtering is
expected in the top left of the kernel.
On 2016/06/08 20:58:49, mtklein wrote:
> // bilerp4() expects xs,ys are the top-lefts of the 2x2 kernel.
> 
> ?

Done.

[commit-bot: I haz the power, 2016-06-08 21:33:17]

Description was changed from

==========
Use faster case for on tile sampling, and a little clean up. This has been a
sampling bug and so was bypassed using "false &&". Found the sampling bug and
added the case back in.

Remove long commented out code.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044373003
==========

to

==========
Use faster case for on tile sampling, and a little clean up. This has been a
sampling bug and so was bypassed using "false &&". Found the sampling bug and
added the case back in.

Remove long commented out code.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044373003

Committed:
https://skia.googlesource.com/skia/+/dd40483534f57df206020c174cb56e2b2c258015
==========

[commit-bot: I haz the power, 2016-06-08 21:33:21]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/dd40483534f57df206020c174cb56e2b2c258015