[Media, Autoplay] Add UMA to record autoplay source

[Media, Autoplay] Add UMA to record autoplay source

This CL adds UMA to record the autoplay source, which could be the
autoplay attribute of HTMLMediaElement, or the `play()` method.

BUG=617948
Committed: https://crrev.com/b69344ad79fc2e36f8eea0e8f0fad3905395cb48
Cr-Commit-Position: refs/heads/master@{#398855}

[Zhiqiang Zhang (Slow), 2016-06-08 11:02:37]

zqzhang@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-06-08 12:30:03]

mlamouri@chromium.org changed reviewers:
+ isherman@chromium.org

[mlamouri (slow - plz ping), 2016-06-08 12:30:04]

+isherman@ for histogarms.

https://codereview.chromium.org/2044373002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2044373002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2062:
recordAutoplaySourceMetric(AutoplaySourceMethod);
What we call "autoplay" is when there is no user gesture associated with the
play() method so I think this should be inside the "if
(!UserGestureIndicator::processingUserGesture())" block.

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3570: +<histogram
name="Blink.MediaElement.Autoplay.Source.Audio"
Usually the media team prefer to have media metrics inside Media.*. I would
suggest to do "Media.Audio.Autoplay" instead of re-using
Blink.MediaElement.Autoplay

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3575: +  <summary>Records the autoplay
source of audible audios.</summary>
I would drop "audible".

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3578: +<histogram
name="Blink.MediaElement.Autoplay.Source.Video"
Media.Video.Autoplay

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3583: +  <summary>Records the autoplay
source of audible videos.</summary>
ditto.

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3586: +<histogram
name="Blink.MediaElement.Autoplay.Source.Video.Muted"
Media.Video.Autoplay.Muted

[Zhiqiang Zhang (Slow), 2016-06-08 12:47:33]

Patchset #3 (id:40001) has been deleted

[Zhiqiang Zhang (Slow), 2016-06-08 12:52:23]

Patchset #3 (id:60001) has been deleted

[Zhiqiang Zhang (Slow), 2016-06-08 12:55:15]

PTAL. Addressed Mounir's comments.

https://codereview.chromium.org/2044373002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2044373002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2062:
recordAutoplaySourceMetric(AutoplaySourceMethod);
On 2016/06/08 12:30:03, Mounir Lamouri (slow) wrote:
> What we call "autoplay" is when there is no user gesture associated with the
> play() method so I think this should be inside the "if
> (!UserGestureIndicator::processingUserGesture())" block.

Done.

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3570: +<histogram
name="Blink.MediaElement.Autoplay.Source.Audio"
On 2016/06/08 12:30:03, Mounir Lamouri (slow) wrote:
> Usually the media team prefer to have media metrics inside Media.*. I would
> suggest to do "Media.Audio.Autoplay" instead of re-using
> Blink.MediaElement.Autoplay

Done.

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3575: +  <summary>Records the autoplay
source of audible audios.</summary>
On 2016/06/08 12:30:04, Mounir Lamouri (slow) wrote:
> I would drop "audible".

Done.

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3578: +<histogram
name="Blink.MediaElement.Autoplay.Source.Video"
On 2016/06/08 12:30:04, Mounir Lamouri (slow) wrote:
> Media.Video.Autoplay

Done.

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3583: +  <summary>Records the autoplay
source of audible videos.</summary>
On 2016/06/08 12:30:03, Mounir Lamouri (slow) wrote:
> ditto.

Done. Also mentioned in the summary that this includes
Media.Video.Autoplay.Muted.

https://codereview.chromium.org/2044373002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:3586: +<histogram
name="Blink.MediaElement.Autoplay.Source.Video.Muted"
On 2016/06/08 12:30:04, Mounir Lamouri (slow) wrote:
> Media.Video.Autoplay.Muted

Done.

[Ilya Sherman, 2016-06-08 22:31:19]

histograms lgtm

[mlamouri (slow - plz ping), 2016-06-09 11:07:27]

lgtm

[Zhiqiang Zhang (Slow), 2016-06-09 11:11:51]

The CQ bit was checked by zqzhang@chromium.org

[commit-bot: I haz the power, 2016-06-09 11:12:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044373002/80001

[commit-bot: I haz the power, 2016-06-09 13:10:24]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-06-09 13:12:46]

Description was changed from

==========
[Media, Autoplay] Add UMA to record autoplay source

This CL adds UMA to record the autoplay source, which could be the
autoplay attribute of HTMLMediaElement, or the `play()` method.

BUG=617948
==========

to

==========
[Media, Autoplay] Add UMA to record autoplay source

This CL adds UMA to record the autoplay source, which could be the
autoplay attribute of HTMLMediaElement, or the `play()` method.

BUG=617948

Committed: https://crrev.com/b69344ad79fc2e36f8eea0e8f0fad3905395cb48
Cr-Commit-Position: refs/heads/master@{#398855}
==========

[commit-bot: I haz the power, 2016-06-09 13:12:48]

Patchset 3 (id:??) landed as
https://crrev.com/b69344ad79fc2e36f8eea0e8f0fad3905395cb48
Cr-Commit-Position: refs/heads/master@{#398855}