Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment addressed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
index 197269755b72a3a631d95f3990757b7fc4d56c24..2a6c8a37187ce35f313a1efcb5936181cc2865a4 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h
@@ -5,9 +5,8 @@
#ifndef V8Debugger_h
#define V8Debugger_h
-#include "platform/PlatformExport.h"
+#include "platform/inspector_protocol/Platform.h"
#include "platform/inspector_protocol/String16.h"
-#include "wtf/PtrUtil.h"
#include <v8.h>
@@ -21,6 +20,7 @@ class V8StackTrace;
namespace protocol {
class DictionaryValue;
+class FrontendChannel;
}
class PLATFORM_EXPORT V8Debugger {
@@ -40,7 +40,7 @@ public:
virtual void idleStarted() = 0;
virtual void idleFinished() = 0;
- virtual std::unique_ptr<V8InspectorSession> connect(int contextGroupId, V8InspectorSessionClient*, const String16* state) = 0;
+ virtual std::unique_ptr<V8InspectorSession> connect(int contextGroupId, protocol::FrontendChannel*, V8InspectorSessionClient*, const String16* state) = 0;
virtual bool isPaused() = 0;
static v8::Local<v8::Private> scopeExtensionPrivate(v8::Isolate*);

Powered by Google App Engine
This is Rietveld 408576698