third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h - Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comment addressed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

index 1bd82d6bc1cc138714553f57c39d8a9a99194ee3..b62a2a003a5661c92e7d894864f5c8dca0ae2c7e 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h

@@ -32,11 +32,11 @@

#define V8DebuggerImpl_h

#include "platform/inspector_protocol/Maybe.h"

+#include "platform/inspector_protocol/Platform.h"

#include "platform/v8_inspector/JavaScriptCallFrame.h"

#include "platform/v8_inspector/V8DebuggerScript.h"

#include "platform/v8_inspector/protocol/Debugger.h"

#include "platform/v8_inspector/public/V8Debugger.h"

-#include "wtf/PtrUtil.h"

#include <v8-debug.h>

#include <v8.h>

@@ -107,7 +107,7 @@ public:

v8::Local<v8::Context> regexContext();

// V8Debugger implementation

- std::unique_ptr<V8InspectorSession> connect(int contextGroupId, V8InspectorSessionClient*, const String16* state) override;

+ std::unique_ptr<V8InspectorSession> connect(int contextGroupId, protocol::FrontendChannel*, V8InspectorSessionClient*, const String16* state) override;

void contextCreated(const V8ContextInfo&) override;

void contextDestroyed(v8::Local<v8::Context>) override;

void resetContextGroup(int contextGroupId) override;