Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp

Issue 2044343002: DevTools: update V8Inspector to work with the new v8_inspector API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comment addressed Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
index 10ca0f6487db1efc963df8a9741c6495cf7712d1..f94aab113f369a78628a35241ffa83f5217f8208 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Console.cpp
@@ -4,6 +4,7 @@
#include "platform/v8_inspector/V8Console.h"
+#include "platform/inspector_protocol/Platform.h"
#include "platform/inspector_protocol/String16.h"
#include "platform/v8_inspector/InjectedScript.h"
#include "platform/v8_inspector/InspectedContext.h"
@@ -714,7 +715,7 @@ bool V8Debugger::isCommandLineAPIMethod(const String16& name)
if (methods.size() == 0) {
const char* members[] = { "dir", "dirxml", "keys", "values", "profile", "profileEnd", "inspect",
"copy", "clear", "debug", "undebug", "monitor", "unmonitor", "table" };
- for (size_t i = 0; i < WTF_ARRAY_LENGTH(members); ++i)
+ for (size_t i = 0; i < PROTOCOL_ARRAY_LENGTH(members); ++i)
methods.add(members[i]);
}
return methods.find(name) != methods.end();
@@ -725,7 +726,7 @@ bool V8Debugger::isCommandLineAPIGetter(const String16& name)
DEFINE_STATIC_LOCAL(protocol::HashSet<String16>, getters, ());
if (getters.size() == 0) {
const char* members[] = { "$0", "$1", "$2", "$3", "$4", "$_" };
- for (size_t i = 0; i < WTF_ARRAY_LENGTH(members); ++i)
+ for (size_t i = 0; i < PROTOCOL_ARRAY_LENGTH(members); ++i)
getters.add(members[i]);
}
return getters.find(name) != getters.end();

Powered by Google App Engine
This is Rietveld 408576698