Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 204433002: Selecting OptGroup label does not deselect selected item (Closed)

Created:
6 years, 9 months ago by Habib Virji
Modified:
6 years, 8 months ago
Reviewers:
keishi, tkent
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Selecting OptGroup label does not deselect selected item OptGroup since it is a label, if selected should not deselect selected item. In updateStateSelected, it is checked if optGroup, no UI changes are triggered. R=keishi1, tkent BUG=342189 TEST=On selecting optGroup label, selectedIndex should not be deselected. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171470

Patch Set 1 #

Patch Set 2 : Updated platform mac expectation file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M LayoutTests/fast/forms/select/optgroup-clicking.html View 1 chunk +6 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/select/optgroup-clicking-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/select/optgroup-clicking-expected.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Habib Virji
A check if OptGroup element, not to update UI and change other state changes of ...
6 years, 9 months ago (2014-03-19 10:21:32 UTC) #1
Habib Virji
There is comment in WHATWG from Ian 'Hixie' Hickson to handle it as label. "It ...
6 years, 8 months ago (2014-04-08 12:50:25 UTC) #2
keishi
Thanks for asking hixie. LGTM
6 years, 8 months ago (2014-04-11 06:03:38 UTC) #3
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 8 months ago (2014-04-11 07:03:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/204433002/1
6 years, 8 months ago (2014-04-11 07:03:47 UTC) #5
Habib Virji
The CQ bit was unchecked by habib.virji@samsung.com
6 years, 8 months ago (2014-04-11 15:01:37 UTC) #6
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 8 months ago (2014-04-11 15:01:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/204433002/1
6 years, 8 months ago (2014-04-11 15:01:50 UTC) #8
Habib Virji
@tkent/keishi: mac_blink_compile_dbg, mac_blink_rel, win_blink_compile_dbg are in pending state for last 3 days. How to resolve ...
6 years, 8 months ago (2014-04-14 08:40:35 UTC) #9
Habib Virji
The CQ bit was unchecked by habib.virji@samsung.com
6 years, 8 months ago (2014-04-14 09:52:26 UTC) #10
Habib Virji
The CQ bit was checked by habib.virji@samsung.com
6 years, 8 months ago (2014-04-14 14:56:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/habib.virji@samsung.com/204433002/20001
6 years, 8 months ago (2014-04-14 14:56:55 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 15:09:12 UTC) #13
Message was sent while issue was closed.
Change committed as 171470

Powered by Google App Engine
This is Rietveld 408576698