Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2044313002: Add basic SkBitmap StructTraitsTest. (Closed)

Created:
4 years, 6 months ago by msw
Modified:
4 years, 6 months ago
Reviewers:
Fady Samuel, reed2, reed1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add basic SkBitmap StructTraitsTest. BUG=618103 TEST=automated R=reed@chromium.org Committed: https://crrev.com/e2e406d650bf90ed420197a38e5da0c438f8e072 Cr-Commit-Position: refs/heads/master@{#398571}

Patch Set 1 #

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M skia/public/interfaces/test/struct_traits_unittest.cc View 1 3 chunks +21 lines, -0 lines 0 comments Download
M skia/public/interfaces/test/traits_test_service.mojom View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
msw
Hey Mike, please take a look; thanks!
4 years, 6 months ago (2016-06-07 23:49:35 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044313002/20001
4 years, 6 months ago (2016-06-07 23:50:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-08 00:48:50 UTC) #6
reed1
I don't know anything about EchoBitmapCallback, but the initialization of the bitmap seems fine. lgtm
4 years, 6 months ago (2016-06-08 12:19:00 UTC) #8
Fady Samuel
test lgtm too fwiw
4 years, 6 months ago (2016-06-08 14:55:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044313002/20001
4 years, 6 months ago (2016-06-08 15:48:22 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-08 15:53:05 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 15:54:50 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e2e406d650bf90ed420197a38e5da0c438f8e072
Cr-Commit-Position: refs/heads/master@{#398571}

Powered by Google App Engine
This is Rietveld 408576698