Convert CFXJSE_Value::ToString to return.

xfa/fxfa/fm2js/xfa_fm2jscontext.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxfa/fm2js/xfa_fm2jscontext.h"
 
 #include <time.h>
 
@@ skipping 557 matching lines @@
           std::unique_ptr<CFXJSE_Value> defaultPropValue(
               new CFXJSE_Value(pIsolate));
           GetObjectDefaultValue(jsObjectValue.get(), defaultPropValue.get());
           if (defaultPropValue->IsNull())
             continue;
 
           dSum += ValueToDouble(pThis, defaultPropValue.get());
           uCount++;
         }
       } else {
-        CFX_ByteString propertyStr;
-        propertyValue->ToString(propertyStr);
         for (int32_t j = 2; j < iLength; j++) {
           argValue->GetObjectPropertyByIdx(j, jsObjectValue.get());
           std::unique_ptr<CFXJSE_Value> newPropertyValue(
               new CFXJSE_Value(pIsolate));
-          jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
-                                           newPropertyValue.get());
+          jsObjectValue->GetObjectProperty(
+              propertyValue->ToString().AsStringC(), newPropertyValue.get());
           if (newPropertyValue->IsNull())
             continue;
 
           dSum += ValueToDouble(pThis, newPropertyValue.get());
           uCount++;
         }
       }
     }
   }
   if (uCount == 0) {
@@ skipping 53 matching lines @@
       argValue->GetObjectPropertyByIdx(1, propertyValue.get());
       argValue->GetObjectPropertyByIdx(2, jsObjectValue.get());
       if (propertyValue->IsNull()) {
         for (int32_t j = 2; j < iLength; j++) {
           argValue->GetObjectPropertyByIdx(j, jsObjectValue.get());
           GetObjectDefaultValue(jsObjectValue.get(), newPropertyValue.get());
           if (!newPropertyValue->IsNull())
             iCount++;
         }
       } else {
-        CFX_ByteString propertyStr;
-        propertyValue->ToString(propertyStr);
         for (int32_t j = 2; j < iLength; j++) {
           argValue->GetObjectPropertyByIdx(j, jsObjectValue.get());
-          jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
-                                           newPropertyValue.get());
+          jsObjectValue->GetObjectProperty(
+              propertyValue->ToString().AsStringC(), newPropertyValue.get());
           iCount += newPropertyValue->IsNull() ? 0 : 1;
         }
       }
     } else if (argValue->IsObject()) {
       std::unique_ptr<CFXJSE_Value> newPropertyValue(
           new CFXJSE_Value(pIsolate));
       GetObjectDefaultValue(argValue.get(), newPropertyValue.get());
       if (!newPropertyValue->IsNull())
         iCount++;
     } else {
@@ skipping 56 matching lines @@
           argValue->GetObjectPropertyByIdx(j, jsObjectValue.get());
           GetObjectDefaultValue(jsObjectValue.get(), newPropertyValue.get());
           if (newPropertyValue->IsNull())
             continue;
 
           uCount++;
           FX_DOUBLE dValue = ValueToDouble(pThis, newPropertyValue.get());
           dMaxValue = (uCount == 1) ? dValue : std::max(dMaxValue, dValue);
         }
       } else {
-        CFX_ByteString propertyStr;
-        propertyValue->ToString(propertyStr);
         for (int32_t j = 2; j < iLength; j++) {
           argValue->GetObjectPropertyByIdx(j, jsObjectValue.get());
-          jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
-                                           newPropertyValue.get());
+          jsObjectValue->GetObjectProperty(
+              propertyValue->ToString().AsStringC(), newPropertyValue.get());
           if (newPropertyValue->IsNull())
             continue;
 
           uCount++;
           FX_DOUBLE dValue = ValueToDouble(pThis, newPropertyValue.get());
           dMaxValue = (uCount == 1) ? dValue : std::max(dMaxValue, dValue);
         }
       }
     } else if (argValue->IsObject()) {
       std::unique_ptr<CFXJSE_Value> newPropertyValue(
@@ skipping 52 matching lines @@
           argValue->GetObjectPropertyByIdx(j, jsObjectValue.get());
           GetObjectDefaultValue(jsObjectValue.get(), newPropertyValue.get());
           if (newPropertyValue->IsNull())
             continue;
 
           uCount++;
           FX_DOUBLE dValue = ValueToDouble(pThis, newPropertyValue.get());
           dMinValue = uCount == 1 ? dValue : std::min(dMinValue, dValue);
         }
       } else {
-        CFX_ByteString propertyStr;
-        propertyValue->ToString(propertyStr);
         for (int32_t j = 2; j < iLength; j++) {
           argValue->GetObjectPropertyByIdx(j, jsObjectValue.get());
-          jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
-                                           newPropertyValue.get());
+          jsObjectValue->GetObjectProperty(
+              propertyValue->ToString().AsStringC(), newPropertyValue.get());
           if (newPropertyValue->IsNull())
             continue;
 
           uCount++;
           FX_DOUBLE dValue = ValueToDouble(pThis, newPropertyValue.get());
           dMinValue = uCount == 1 ? dValue : std::min(dMinValue, dValue);
         }
       }
     } else if (argValue->IsObject()) {
       std::unique_ptr<CFXJSE_Value> newPropertyValue(
@@ skipping 139 matching lines @@
         for (int32_t j = 2; j < iLength; j++) {
           argValue->GetObjectPropertyByIdx(j, jsObjectValue.get());
           GetObjectDefaultValue(jsObjectValue.get(), newPropertyValue.get());
           if (newPropertyValue->IsNull())
             continue;
 
           dSum += ValueToDouble(pThis, jsObjectValue.get());
           uCount++;
         }
       } else {
-        CFX_ByteString propertyStr;
-        propertyValue->ToString(propertyStr);
         for (int32_t j = 2; j < iLength; j++) {
           argValue->GetObjectPropertyByIdx(j, jsObjectValue.get());
-          jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
-                                           newPropertyValue.get());
+          jsObjectValue->GetObjectProperty(
+              propertyValue->ToString().AsStringC(), newPropertyValue.get());
           if (newPropertyValue->IsNull())
             continue;
 
           dSum += ValueToDouble(pThis, newPropertyValue.get());
           uCount++;
         }
       }
     } else if (argValue->IsObject()) {
       std::unique_ptr<CFXJSE_Value> newPropertyValue(
           new CFXJSE_Value(pIsolate));
@@ skipping 1827 matching lines @@
         std::unique_ptr<CFXJSE_Value> propertyValue(new CFXJSE_Value(pIsolate));
         std::unique_ptr<CFXJSE_Value> jsObjectValue(new CFXJSE_Value(pIsolate));
         std::unique_ptr<CFXJSE_Value> newPropertyValue(
             new CFXJSE_Value(pIsolate));
         argIndexValue->GetObjectPropertyByIdx(1, propertyValue.get());
         argIndexValue->GetObjectPropertyByIdx(
             (iLength - 1) - (iValueIndex - iIndex), jsObjectValue.get());
         if (propertyValue->IsNull()) {
           GetObjectDefaultValue(jsObjectValue.get(), newPropertyValue.get());
         } else {
-          CFX_ByteString propStr;
-          propertyValue->ToString(propStr);
-          jsObjectValue->GetObjectProperty(propStr.AsStringC(),
-                                           newPropertyValue.get());
+          jsObjectValue->GetObjectProperty(
+              propertyValue->ToString().AsStringC(), newPropertyValue.get());
         }
         CFX_ByteString bsChoosed;
         ValueToUTF8String(newPropertyValue.get(), bsChoosed);
         args.GetReturnValue()->SetString(bsChoosed.AsStringC());
         bFound = TRUE;
       }
     } else {
       iValueIndex++;
       if (iValueIndex == iIndex) {
         CFX_ByteString bsChoosed;
@@ skipping 30 matching lines @@
     return;
   }
 
   std::unique_ptr<CFXJSE_Value> argOne = GetSimpleValue(pThis, args, 0);
   if (!argOne->IsString()) {
     args.GetReturnValue()->SetInteger(argOne->IsNumber() ||
                                       argOne->IsBoolean());
     return;
   }
 
-  CFX_ByteString valueStr;
-  argOne->ToString(valueStr);
+  CFX_ByteString valueStr = argOne->ToString();
   valueStr.TrimLeft();
   args.GetReturnValue()->SetInteger(!valueStr.IsEmpty());
 }
 
 // static
 void CXFA_FM2JSContext::Oneof(CFXJSE_Value* pThis,
                               const CFX_ByteStringC& szFuncName,
                               CFXJSE_Arguments& args) {
   if (args.GetLength() < 2) {
     ToJSContext(pThis, nullptr)
@@ skipping 2174 matching lines @@
     lValue->GetObjectPropertyByIdx(1, propertyValue.get());
     if (propertyValue->IsNull()) {
       for (int32_t i = 2; i < iLeftLength; i++) {
         lValue->GetObjectPropertyByIdx(i, jsObjectValue.get());
         if (!SetObjectDefaultValue(jsObjectValue.get(), rValue.get())) {
           pContext->ThrowException(XFA_IDS_NOT_DEFAUL_VALUE);
           return;
         }
       }
     } else {
-      CFX_ByteString propertyStr;
-      propertyValue->ToString(propertyStr);
       for (int32_t i = 2; i < iLeftLength; i++) {
         lValue->GetObjectPropertyByIdx(i, jsObjectValue.get());
-        jsObjectValue->SetObjectProperty(propertyStr.AsStringC(), rValue.get());
+        jsObjectValue->SetObjectProperty(propertyValue->ToString().AsStringC(),
+                                         rValue.get());
       }
     }
   } else if (lValue->IsObject()) {
     if (!SetObjectDefaultValue(lValue.get(), rValue.get())) {
       pContext->ThrowException(XFA_IDS_NOT_DEFAUL_VALUE);
       return;
     }
   }
   args.GetReturnValue()->Assign(rValue.get());
 }
@@ skipping 56 matching lines @@
 
   std::unique_ptr<CFXJSE_Value> argFirst = GetSimpleValue(pThis, args, 0);
   std::unique_ptr<CFXJSE_Value> argSecond = GetSimpleValue(pThis, args, 1);
   if (argFirst->IsNull() || argSecond->IsNull()) {
     args.GetReturnValue()->SetInteger(
         (argFirst->IsNull() && argSecond->IsNull()) ? 1 : 0);
     return;
   }
 
   if (argFirst->IsString() && argSecond->IsString()) {
-    CFX_ByteString firstOutput;
-    CFX_ByteString secondOutput;
-    argFirst->ToString(firstOutput);
-    argSecond->ToString(secondOutput);
-    args.GetReturnValue()->SetInteger(firstOutput == secondOutput);
+    args.GetReturnValue()->SetInteger(argFirst->ToString() ==
+                                      argSecond->ToString());
     return;
   }
 
   FX_DOUBLE first = ValueToDouble(pThis, argFirst.get());
   FX_DOUBLE second = ValueToDouble(pThis, argSecond.get());
   args.GetReturnValue()->SetInteger((first == second) ? 1 : 0);
 }
 
 // static
 void CXFA_FM2JSContext::notequality_operator(CFXJSE_Value* pThis,
@@ skipping 11 matching lines @@
 
   std::unique_ptr<CFXJSE_Value> argFirst = GetSimpleValue(pThis, args, 0);
   std::unique_ptr<CFXJSE_Value> argSecond = GetSimpleValue(pThis, args, 1);
   if (argFirst->IsNull() || argSecond->IsNull()) {
     args.GetReturnValue()->SetInteger(
         (argFirst->IsNull() && argSecond->IsNull()) ? 0 : 1);
     return;
   }
 
   if (argFirst->IsString() && argSecond->IsString()) {
-    CFX_ByteString firstOutput;
-    CFX_ByteString secondOutput;
-    argFirst->ToString(firstOutput);
-    argSecond->ToString(secondOutput);
-    args.GetReturnValue()->SetInteger(firstOutput != secondOutput);
+    args.GetReturnValue()->SetInteger(argFirst->ToString() !=
+                                      argSecond->ToString());
     return;
   }
 
   FX_DOUBLE first = ValueToDouble(pThis, argFirst.get());
   FX_DOUBLE second = ValueToDouble(pThis, argSecond.get());
   args.GetReturnValue()->SetInteger(first != second);
 }
 
 // static
 FX_BOOL CXFA_FM2JSContext::fm_ref_equal(CFXJSE_Value* pThis,
@@ skipping 32 matching lines @@
   }
 
   std::unique_ptr<CFXJSE_Value> argFirst = GetSimpleValue(pThis, args, 0);
   std::unique_ptr<CFXJSE_Value> argSecond = GetSimpleValue(pThis, args, 1);
   if (argFirst->IsNull() || argSecond->IsNull()) {
     args.GetReturnValue()->SetInteger(0);
     return;
   }
 
   if (argFirst->IsString() && argSecond->IsString()) {
-    CFX_ByteString firstOutput;
-    CFX_ByteString secondOutput;
-    argFirst->ToString(firstOutput);
-    argSecond->ToString(secondOutput);
     args.GetReturnValue()->SetInteger(
-        firstOutput.Compare(secondOutput.AsStringC()) == -1);
+        argFirst->ToString().Compare(argSecond->ToString().AsStringC()) == -1);
     return;
   }
 
   FX_DOUBLE first = ValueToDouble(pThis, argFirst.get());
   FX_DOUBLE second = ValueToDouble(pThis, argSecond.get());
   args.GetReturnValue()->SetInteger((first < second) ? 1 : 0);
 }
 
 // static
 void CXFA_FM2JSContext::lessequal_operator(CFXJSE_Value* pThis,
                                            const CFX_ByteStringC& szFuncName,
                                            CFXJSE_Arguments& args) {
   if (args.GetLength() != 2) {
     ToJSContext(pThis, nullptr)->ThrowException(XFA_IDS_COMPILER_ERROR);
     return;
   }
 
   std::unique_ptr<CFXJSE_Value> argFirst = GetSimpleValue(pThis, args, 0);
   std::unique_ptr<CFXJSE_Value> argSecond = GetSimpleValue(pThis, args, 1);
   if (argFirst->IsNull() || argSecond->IsNull()) {
     args.GetReturnValue()->SetInteger(
         (argFirst->IsNull() && argSecond->IsNull()) ? 1 : 0);
     return;
   }
 
   if (argFirst->IsString() && argSecond->IsString()) {
-    CFX_ByteString firstOutput;
-    CFX_ByteString secondOutput;
-    argFirst->ToString(firstOutput);
-    argSecond->ToString(secondOutput);
     args.GetReturnValue()->SetInteger(
-        firstOutput.Compare(secondOutput.AsStringC()) != 1);
+        argFirst->ToString().Compare(argSecond->ToString().AsStringC()) != 1);
     return;
   }
 
   FX_DOUBLE first = ValueToDouble(pThis, argFirst.get());
   FX_DOUBLE second = ValueToDouble(pThis, argSecond.get());
   args.GetReturnValue()->SetInteger((first <= second) ? 1 : 0);
 }
 
 // static
 void CXFA_FM2JSContext::greater_operator(CFXJSE_Value* pThis,
                                          const CFX_ByteStringC& szFuncName,
                                          CFXJSE_Arguments& args) {
   if (args.GetLength() != 2) {
     ToJSContext(pThis, nullptr)->ThrowException(XFA_IDS_COMPILER_ERROR);
     return;
   }
 
   std::unique_ptr<CFXJSE_Value> argFirst = GetSimpleValue(pThis, args, 0);
   std::unique_ptr<CFXJSE_Value> argSecond = GetSimpleValue(pThis, args, 1);
   if (argFirst->IsNull() || argSecond->IsNull()) {
     args.GetReturnValue()->SetInteger(0);
     return;
   }
 
   if (argFirst->IsString() && argSecond->IsString()) {
-    CFX_ByteString firstOutput;
-    CFX_ByteString secondOutput;
-    argFirst->ToString(firstOutput);
-    argSecond->ToString(secondOutput);
     args.GetReturnValue()->SetInteger(
-        firstOutput.Compare(secondOutput.AsStringC()) == 1);
+        argFirst->ToString().Compare(argSecond->ToString().AsStringC()) == 1);
     return;
   }
 
   FX_DOUBLE first = ValueToDouble(pThis, argFirst.get());
   FX_DOUBLE second = ValueToDouble(pThis, argSecond.get());
   args.GetReturnValue()->SetInteger((first > second) ? 1 : 0);
 }
 
 // static
 void CXFA_FM2JSContext::greaterequal_operator(CFXJSE_Value* pThis,
                                               const CFX_ByteStringC& szFuncName,
                                               CFXJSE_Arguments& args) {
   if (args.GetLength() != 2) {
     ToJSContext(pThis, nullptr)->ThrowException(XFA_IDS_COMPILER_ERROR);
     return;
   }
 
   std::unique_ptr<CFXJSE_Value> argFirst = GetSimpleValue(pThis, args, 0);
   std::unique_ptr<CFXJSE_Value> argSecond = GetSimpleValue(pThis, args, 1);
   if (argFirst->IsNull() || argSecond->IsNull()) {
     args.GetReturnValue()->SetInteger(
         (argFirst->IsNull() && argSecond->IsNull()) ? 1 : 0);
     return;
   }
 
   if (argFirst->IsString() && argSecond->IsString()) {
-    CFX_ByteString firstOutput;
-    CFX_ByteString secondOutput;
-    argFirst->ToString(firstOutput);
-    argSecond->ToString(secondOutput);
     args.GetReturnValue()->SetInteger(
-        firstOutput.Compare(secondOutput.AsStringC()) != -1);
+        argFirst->ToString().Compare(argSecond->ToString().AsStringC()) != -1);
     return;
   }
 
   FX_DOUBLE first = ValueToDouble(pThis, argFirst.get());
   FX_DOUBLE second = ValueToDouble(pThis, argSecond.get());
   args.GetReturnValue()->SetInteger((first >= second) ? 1 : 0);
 }
 
 // static
 void CXFA_FM2JSContext::plus_operator(CFXJSE_Value* pThis,
@@ skipping 499 matching lines @@
     v8::Isolate* pIsolate = pContext->GetScriptRuntime();
     std::unique_ptr<CFXJSE_Value> propertyValue(new CFXJSE_Value(pIsolate));
     std::unique_ptr<CFXJSE_Value> jsObjectValue(new CFXJSE_Value(pIsolate));
     argOne->GetObjectPropertyByIdx(1, propertyValue.get());
     argOne->GetObjectPropertyByIdx(2, jsObjectValue.get());
     if (propertyValue->IsNull()) {
       GetObjectDefaultValue(jsObjectValue.get(), args.GetReturnValue());
       return;
     }
 
-    CFX_ByteString propertyStr;
-    propertyValue->ToString(propertyStr);
-    jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
+    jsObjectValue->GetObjectProperty(propertyValue->ToString().AsStringC(),
                                      args.GetReturnValue());
     return;
   }
 
   if (argOne->IsObject()) {
     GetObjectDefaultValue(argOne.get(), args.GetReturnValue());
     return;
   }
 
   args.GetReturnValue()->Assign(argOne.get());
@@ skipping 150 matching lines @@
 
     std::unique_ptr<CFXJSE_Value> propertyValue(new CFXJSE_Value(pIsolate));
     std::unique_ptr<CFXJSE_Value> jsObjectValue(new CFXJSE_Value(pIsolate));
     argIndex->GetObjectPropertyByIdx(1, propertyValue.get());
     argIndex->GetObjectPropertyByIdx(2, jsObjectValue.get());
     if (propertyValue->IsNull()) {
       GetObjectDefaultValue(jsObjectValue.get(), simpleValue.get());
       return simpleValue;
     }
 
-    CFX_ByteString propertyStr;
-    propertyValue->ToString(propertyStr);
-    jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
+    jsObjectValue->GetObjectProperty(propertyValue->ToString().AsStringC(),
                                      simpleValue.get());
     return simpleValue;
   }
 
   std::unique_ptr<CFXJSE_Value> defaultValue(new CFXJSE_Value(pIsolate));
   GetObjectDefaultValue(argIndex.get(), defaultValue.get());
   return defaultValue;
 }
 
 // static
@@ skipping 13 matching lines @@
     std::unique_ptr<CFXJSE_Value> propertyValue(new CFXJSE_Value(pIsolate));
     std::unique_ptr<CFXJSE_Value> jsObjectValue(new CFXJSE_Value(pIsolate));
     arg->GetObjectPropertyByIdx(1, propertyValue.get());
     arg->GetObjectPropertyByIdx(2, jsObjectValue.get());
     if (propertyValue->IsNull()) {
       std::unique_ptr<CFXJSE_Value> defaultValue(new CFXJSE_Value(pIsolate));
       GetObjectDefaultValue(jsObjectValue.get(), defaultValue.get());
       return defaultValue->IsNull();
     }
 
-    CFX_ByteString propertyStr;
-    propertyValue->ToString(propertyStr);
     std::unique_ptr<CFXJSE_Value> newPropertyValue(new CFXJSE_Value(pIsolate));
-    jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
+    jsObjectValue->GetObjectProperty(propertyValue->ToString().AsStringC(),
                                      newPropertyValue.get());
     return newPropertyValue->IsNull();
   }
 
   std::unique_ptr<CFXJSE_Value> defaultValue(new CFXJSE_Value(pIsolate));
   GetObjectDefaultValue(arg, defaultValue.get());
   return defaultValue->IsNull();
 }
 
 // static
@@ skipping 70 matching lines @@
       std::unique_ptr<CFXJSE_Value> propertyValue(new CFXJSE_Value(pIsolate));
       std::unique_ptr<CFXJSE_Value> jsObjectValue(new CFXJSE_Value(pIsolate));
       argsValue[i]->GetObjectPropertyByIdx(1, propertyValue.get());
       if (propertyValue->IsNull()) {
         for (int32_t j = 2; j < iLength; j++) {
           argsValue[i]->GetObjectPropertyByIdx(j, jsObjectValue.get());
           GetObjectDefaultValue(jsObjectValue.get(), resultValues[index]);
           index++;
         }
       } else {
-        CFX_ByteString propertyString;
-        propertyValue->ToString(propertyString);
         for (int32_t j = 2; j < iLength; j++) {
           argsValue[i]->GetObjectPropertyByIdx(j, jsObjectValue.get());
-          jsObjectValue->GetObjectProperty(propertyString.AsStringC(),
-                                           resultValues[index]);
+          jsObjectValue->GetObjectProperty(
+              propertyValue->ToString().AsStringC(), resultValues[index]);
           index++;
         }
       }
     } else if (argsValue[i]->IsObject()) {
       GetObjectDefaultValue(argsValue[i].get(), resultValues[index]);
       index++;
     } else {
       resultValues[index]->Assign(argsValue[i].get());
       index++;
     }
@@ skipping 186 matching lines @@
     std::unique_ptr<CFXJSE_Value> propertyValue(new CFXJSE_Value(pIsolate));
     std::unique_ptr<CFXJSE_Value> jsObjectValue(new CFXJSE_Value(pIsolate));
     std::unique_ptr<CFXJSE_Value> newPropertyValue(new CFXJSE_Value(pIsolate));
     pValue->GetObjectPropertyByIdx(1, propertyValue.get());
     pValue->GetObjectPropertyByIdx(2, jsObjectValue.get());
     if (propertyValue->IsNull()) {
       GetObjectDefaultValue(jsObjectValue.get(), newPropertyValue.get());
       return ValueToInteger(pThis, newPropertyValue.get());
     }
 
-    CFX_ByteString propertyStr;
-    propertyValue->ToString(propertyStr);
-    jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
+    jsObjectValue->GetObjectProperty(propertyValue->ToString().AsStringC(),
                                      newPropertyValue.get());
     return ValueToInteger(pThis, newPropertyValue.get());
   }
   if (pValue->IsObject()) {
     std::unique_ptr<CFXJSE_Value> newPropertyValue(new CFXJSE_Value(pIsolate));
     GetObjectDefaultValue(pValue, newPropertyValue.get());
     return ValueToInteger(pThis, newPropertyValue.get());
   }
-  if (pValue->IsString()) {
-    CFX_ByteString szValue;
-    pValue->ToString(szValue);
-    return FXSYS_atoi(szValue.c_str());
-  }
+  if (pValue->IsString())
+    return FXSYS_atoi(pValue->ToString().c_str());
   return pValue->ToInteger();
 }
 
 // static
 FX_FLOAT CXFA_FM2JSContext::ValueToFloat(CFXJSE_Value* pThis,
                                          CFXJSE_Value* arg) {
   if (!arg)
     return 0.0f;
 
   v8::Isolate* pIsolate = ToJSContext(pThis, nullptr)->GetScriptRuntime();
   if (arg->IsArray()) {
     std::unique_ptr<CFXJSE_Value> propertyValue(new CFXJSE_Value(pIsolate));
     std::unique_ptr<CFXJSE_Value> jsObjectValue(new CFXJSE_Value(pIsolate));
     std::unique_ptr<CFXJSE_Value> newPropertyValue(new CFXJSE_Value(pIsolate));
     arg->GetObjectPropertyByIdx(1, propertyValue.get());
     arg->GetObjectPropertyByIdx(2, jsObjectValue.get());
     if (propertyValue->IsNull()) {
       GetObjectDefaultValue(jsObjectValue.get(), newPropertyValue.get());
       return ValueToFloat(pThis, newPropertyValue.get());
     }
-    CFX_ByteString propertyStr;
-    propertyValue->ToString(propertyStr);
-    jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
+    jsObjectValue->GetObjectProperty(propertyValue->ToString().AsStringC(),
                                      newPropertyValue.get());
     return ValueToFloat(pThis, newPropertyValue.get());
   }
   if (arg->IsObject()) {
     std::unique_ptr<CFXJSE_Value> newPropertyValue(new CFXJSE_Value(pIsolate));
     GetObjectDefaultValue(arg, newPropertyValue.get());
     return ValueToFloat(pThis, newPropertyValue.get());
   }
-  if (arg->IsString()) {
-    CFX_ByteString bsOutput;
-    arg->ToString(bsOutput);
-    return (FX_FLOAT)XFA_ByteStringToDouble(bsOutput.AsStringC());
-  }
+  if (arg->IsString())
+    return (FX_FLOAT)XFA_ByteStringToDouble(arg->ToString().AsStringC());
   if (arg->IsUndefined())
     return 0;
 
   return arg->ToFloat();
 }
 
 // static
 FX_DOUBLE CXFA_FM2JSContext::ValueToDouble(CFXJSE_Value* pThis,
                                            CFXJSE_Value* arg) {
   if (!arg)
     return 0;
 
   v8::Isolate* pIsolate = ToJSContext(pThis, nullptr)->GetScriptRuntime();
   if (arg->IsArray()) {
     std::unique_ptr<CFXJSE_Value> propertyValue(new CFXJSE_Value(pIsolate));
     std::unique_ptr<CFXJSE_Value> jsObjectValue(new CFXJSE_Value(pIsolate));
     std::unique_ptr<CFXJSE_Value> newPropertyValue(new CFXJSE_Value(pIsolate));
     arg->GetObjectPropertyByIdx(1, propertyValue.get());
     arg->GetObjectPropertyByIdx(2, jsObjectValue.get());
     if (propertyValue->IsNull()) {
       GetObjectDefaultValue(jsObjectValue.get(), newPropertyValue.get());
       return ValueToDouble(pThis, newPropertyValue.get());
     }
-    CFX_ByteString propertyStr;
-    propertyValue->ToString(propertyStr);
-    jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
+    jsObjectValue->GetObjectProperty(propertyValue->ToString().AsStringC(),
                                      newPropertyValue.get());
     return ValueToDouble(pThis, newPropertyValue.get());
   }
   if (arg->IsObject()) {
     std::unique_ptr<CFXJSE_Value> newPropertyValue(new CFXJSE_Value(pIsolate));
     GetObjectDefaultValue(arg, newPropertyValue.get());
     return ValueToDouble(pThis, newPropertyValue.get());
   }
-  if (arg->IsString()) {
-    CFX_ByteString bsOutput;
-    arg->ToString(bsOutput);
-    return XFA_ByteStringToDouble(bsOutput.AsStringC());
-  }
+  if (arg->IsString())
+    return XFA_ByteStringToDouble(arg->ToString().AsStringC());
   if (arg->IsUndefined())
     return 0;
   return arg->ToDouble();
 }
 
 // static.
 double CXFA_FM2JSContext::ExtractDouble(CFXJSE_Value* pThis,
                                         CFXJSE_Value* src,
                                         bool* ret) {
   ASSERT(ret);
@@ skipping 14 matching lines @@
     return 0.0;
   }
 
   std::unique_ptr<CFXJSE_Value> propertyValue(new CFXJSE_Value(pIsolate));
   std::unique_ptr<CFXJSE_Value> jsObjectValue(new CFXJSE_Value(pIsolate));
   src->GetObjectPropertyByIdx(1, propertyValue.get());
   src->GetObjectPropertyByIdx(2, jsObjectValue.get());
   if (propertyValue->IsNull())
     return ValueToDouble(pThis, jsObjectValue.get());
 
-  CFX_ByteString propertyStr;
-  propertyValue->ToString(propertyStr);
   std::unique_ptr<CFXJSE_Value> newPropertyValue(new CFXJSE_Value(pIsolate));
-  jsObjectValue->GetObjectProperty(propertyStr.AsStringC(),
+  jsObjectValue->GetObjectProperty(propertyValue->ToString().AsStringC(),
                                    newPropertyValue.get());
   return ValueToDouble(pThis, newPropertyValue.get());
 }
 
 // static
 void CXFA_FM2JSContext::ValueToUTF8String(CFXJSE_Value* arg,
                                           CFX_ByteString& szOutputString) {
   if (!arg)
     return;
 
-  if (arg->IsNull() || arg->IsUndefined()) {
+  if (arg->IsNull() || arg->IsUndefined())
     szOutputString = "";
-  } else if (arg->IsBoolean()) {
+  else if (arg->IsBoolean())
     szOutputString = arg->ToBoolean() ? "1" : "0";
-  } else {
-    szOutputString = "";
-    arg->ToString(szOutputString);
-  }
+  else
+    szOutputString = arg->ToString();
 }
 
 // static.
 int32_t CXFA_FM2JSContext::Translate(const CFX_WideStringC& wsFormcalc,
                                      CFX_WideTextBuf& wsJavascript,
                                      CFX_WideString& wsError) {
   if (wsFormcalc.IsEmpty()) {
     wsJavascript.Clear();
     wsError.clear();
     return 0;
@@ skipping 38 matching lines @@
   CFX_WideString wsFormat;
   pAppProvider->LoadString(iStringID, wsFormat);
   CFX_WideString wsMessage;
   va_list arg_ptr;
   va_start(arg_ptr, iStringID);
   wsMessage.FormatV(wsFormat.c_str(), arg_ptr);
   va_end(arg_ptr);
   FXJSE_ThrowMessage(
       FX_UTF8Encode(wsMessage.c_str(), wsMessage.GetLength()).AsStringC());
 }