Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2044293002: Update Port.is_wpt_test to check for wpt instead of web-platform-tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 1152 matching lines...) Expand 10 before | Expand all | Expand 10 after
1163 server = pywebsocket.PyWebSocket(self, self.results_directory()) 1163 server = pywebsocket.PyWebSocket(self, self.results_directory())
1164 server.start() 1164 server.start()
1165 self._websocket_server = server 1165 self._websocket_server = server
1166 1166
1167 def is_wpt_enabled(self): 1167 def is_wpt_enabled(self):
1168 """Used as feature flag for WPT Serve feature.""" 1168 """Used as feature flag for WPT Serve feature."""
1169 return self._is_wpt_enabled 1169 return self._is_wpt_enabled
1170 1170
1171 def is_wpt_test(self, test): 1171 def is_wpt_test(self, test):
1172 """Whether this test is part of a web-platform-tests which require wptse rve servers.""" 1172 """Whether this test is part of a web-platform-tests which require wptse rve servers."""
1173 return "web-platform-tests" in test 1173 return test.startswith("imported/wpt/")
1174 1174
1175 def start_wptserve(self): 1175 def start_wptserve(self):
1176 """Start a WPT web server. Raise an error if it can't start or is alread y running. 1176 """Start a WPT web server. Raise an error if it can't start or is alread y running.
1177 1177
1178 Ports can stub this out if they don't need a WPT web server to be runnin g.""" 1178 Ports can stub this out if they don't need a WPT web server to be runnin g."""
1179 assert not self._wpt_server, 'Already running an http server.' 1179 assert not self._wpt_server, 'Already running an http server.'
1180 assert self.is_wpt_enabled(), 'Cannot start server if WPT is not enabled .' 1180 assert self.is_wpt_enabled(), 'Cannot start server if WPT is not enabled .'
1181 1181
1182 # We currently don't support any output mechanism for the WPT server. 1182 # We currently don't support any output mechanism for the WPT server.
1183 server = wptserve.WPTServe(self, self.results_directory()) 1183 server = wptserve.WPTServe(self, self.results_directory())
(...skipping 600 matching lines...) Expand 10 before | Expand all | Expand 10 after
1784 1784
1785 def __init__(self, base, args, reference_args=None): 1785 def __init__(self, base, args, reference_args=None):
1786 self.name = base 1786 self.name = base
1787 self.base = base 1787 self.base = base
1788 self.args = args 1788 self.args = args
1789 self.reference_args = args if reference_args is None else reference_args 1789 self.reference_args = args if reference_args is None else reference_args
1790 self.tests = set() 1790 self.tests = set()
1791 1791
1792 def __repr__(self): 1792 def __repr__(self):
1793 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args) 1793 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698