Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: lib/src/runner/browser/compiler_pool.dart

Issue 2044263002: Silence dart2js's success output. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/compiler_pool.dart
diff --git a/lib/src/runner/browser/compiler_pool.dart b/lib/src/runner/browser/compiler_pool.dart
index cb240f41d98fe83ed273f4ba100035968a456309..6503db516f75d4ff5f3665ae45982bb4237955f9 100644
--- a/lib/src/runner/browser/compiler_pool.dart
+++ b/lib/src/runner/browser/compiler_pool.dart
@@ -14,6 +14,10 @@ import '../../util/io.dart';
import '../configuration.dart';
import '../load_exception.dart';
+/// A regular expression matching the first status line printed by dart2js.
+final _dart2jsStatus =
+ new RegExp(r"^Dart file \(.*\) compiled to JavaScript: .*\n?");
+
/// A pool of `dart2js` instances.
///
/// This limits the number of compiler instances running concurrently.
@@ -102,7 +106,8 @@ class CompilerPool {
_processes.remove(process);
if (_closed) return;
- if (buffer.isNotEmpty) print(buffer);
+ var output = buffer.toString().replaceFirst(_dart2jsStatus, '');
+ if (output.isNotEmpty) print(output);
if (exitCode != 0) throw new LoadException(dartPath, "dart2js failed.");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698