Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2044253004: Revert of cc : Make LayerImpl destruction independent of tree hierarchy (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
jaydasika, ajuma, weiliangc
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc : Make LayerImpl destruction independent of tree hierarchy (patchset #2 id:20001 of https://codereview.chromium.org/2043963005/ ) Reason for revert: Didn't fix anything. Original issue's description: > cc : Make LayerImpl destruction independent of tree hierarchy > > Instead of deleting all layers when the root is deleted, we delete > all layers when the layer tree impl is shutdown. > > BUG=617791 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/e536d2292fa548ee6231ff23ac65203c261e4a14 > Cr-Commit-Position: refs/heads/master@{#398606} TBR=ajuma@chromium.org,weiliangc@chromium.org,jaydasika@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=617791 Committed: https://crrev.com/ef1625ae9feafee9ddaa2a58b9476175d7956b8b Cr-Commit-Position: refs/heads/master@{#398633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -30 lines) Patch
M cc/layers/layer_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 3 chunks +13 lines, -9 lines 0 comments Download
M cc/layers/picture_layer_impl_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M cc/trees/tree_synchronizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Ken Rockot(use gerrit already)
Created Revert of cc : Make LayerImpl destruction independent of tree hierarchy
4 years, 6 months ago (2016-06-08 19:06:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044253004/1
4 years, 6 months ago (2016-06-08 19:07:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 19:09:01 UTC) #5
ajuma
On 2016/06/08 19:06:37, Ken Rockot wrote: > Created Revert of cc : Make LayerImpl destruction ...
4 years, 6 months ago (2016-06-08 19:09:59 UTC) #6
Ken Rockot(use gerrit already)
Yep thanks On Wed, Jun 8, 2016 at 12:09 PM, <ajuma@chromium.org> wrote: > On 2016/06/08 ...
4 years, 6 months ago (2016-06-08 19:10:18 UTC) #7
ajuma
Sadly I was too late :( On 2016/06/08 19:10:18, Ken Rockot wrote: > Yep thanks ...
4 years, 6 months ago (2016-06-08 19:11:03 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ef1625ae9feafee9ddaa2a58b9476175d7956b8b Cr-Commit-Position: refs/heads/master@{#398633}
4 years, 6 months ago (2016-06-08 19:11:26 UTC) #10
Ken Rockot(use gerrit already)
4 years, 6 months ago (2016-06-08 19:15:59 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2049883002/ by rockot@chromium.org.

The reason for reverting is: around and around we go :D.

Powered by Google App Engine
This is Rietveld 408576698