Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2044233002: Remove download resumption feature flag. (Closed)

Created:
4 years, 6 months ago by asanka
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove download resumption feature flag. The feature is now available by default. We no longer need a feature flag. BUG=7648 Committed: https://crrev.com/fac8aa8c63e77e543d6ea0afe4de1929be4c8194 Cr-Commit-Position: refs/heads/master@{#398438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -79 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/download/download_shelf_context_menu.cc View 3 chunks +5 lines, -27 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/download/download_item_impl.cc View 4 chunks +2 lines, -13 lines 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_features.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
asanka
jam: PTAL?
4 years, 6 months ago (2016-06-07 20:29:49 UTC) #2
jam
lgtm
4 years, 6 months ago (2016-06-07 22:16:49 UTC) #3
asanka
On 2016/06/07 at 22:16:49, jam wrote: > lgtm Thanks!
4 years, 6 months ago (2016-06-08 00:34:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044233002/1
4 years, 6 months ago (2016-06-08 00:35:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 00:41:31 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 00:43:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fac8aa8c63e77e543d6ea0afe4de1929be4c8194
Cr-Commit-Position: refs/heads/master@{#398438}

Powered by Google App Engine
This is Rietveld 408576698