Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1879)

Unified Diff: chrome/browser/ui/views/status_bubble_views.cc

Issue 2044223006: Make toolbar color opaque in browser theme (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make toolbar_color opaque Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/themes/browser_theme_pack.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/status_bubble_views.cc
diff --git a/chrome/browser/ui/views/status_bubble_views.cc b/chrome/browser/ui/views/status_bubble_views.cc
index 92c437decbe72b8d7daead0eb65133ce70bd550d..83b1a11ed8c4ab207d9081bdc6f0b0cfa87c10b8 100644
--- a/chrome/browser/ui/views/status_bubble_views.cc
+++ b/chrome/browser/ui/views/status_bubble_views.cc
@@ -371,6 +371,10 @@ void StatusBubbleViews::StatusView::OnPaint(gfx::Canvas* canvas) {
paint.setAntiAlias(true);
SkColor toolbar_color = theme_provider_->GetColor(
ThemeProperties::COLOR_TOOLBAR);
+ // The status bubble is intentionally set to ignore the alpha value of
+ // toolbar_color, see crbug.com/618278. A partly transparent color with
+ // subpixel rendering of the text may result in weird font in the status
+ // bubble.
Peter Kasting 2016/06/29 23:25:36 This comment is no longer necessary.
sunxd 2016/07/01 20:58:06 Done.
paint.setColor(toolbar_color);
gfx::Rect popup_bounds = popup_->GetWindowBoundsInScreen();
« no previous file with comments | « chrome/browser/themes/browser_theme_pack.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698