Make toolbar color opaque in browser theme

chrome/browser/themes/browser_theme_pack.cc

Index: chrome/browser/themes/browser_theme_pack.cc
diff --git a/chrome/browser/themes/browser_theme_pack.cc b/chrome/browser/themes/browser_theme_pack.cc
index 70e81a834842847ff7612a322891752d73e20f6c..1edf4a678ef13102ba4a8597f1d270dfa398cc93 100644
--- a/chrome/browser/themes/browser_theme_pack.cc
+++ b/chrome/browser/themes/browser_theme_pack.cc
@@ -790,6 +790,12 @@ bool BrowserThemePack::GetColor(int id, SkColor* color) const {
     for (size_t i = 0; i < kColorTableLength; ++i) {
       if (colors_[i].id == id) {
         *color = colors_[i].color;
+        // The theme provider is intentionally made to ignore the alpha value of
+        // toolbar color, see crbug.com/618278.

[Peter Kasting, 2016/07/01 21:03:14]

Nit: Avoid referring to bugs in comments, and just give sufficient contet
inline; something like "Ignore alpha for the toolbar color, as we don't want to
allow transparent toolbars."

+        if (id == ThemeProperties::COLOR_TOOLBAR) {
+          *color = SkColorSetARGB(SK_AlphaOPAQUE, SkColorGetR(*color),
+                                  SkColorGetG(*color), SkColorGetB(*color));

[Peter Kasting, 2016/07/01 21:03:14]

Nit: Just:

  *color = SkColorSetA(*color, SK_AlphaOPAQUE);

+        }
         return true;
       }
     }