Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2044223002: Remove ifdefs for neon in row_neon*.cc (Closed)

Created:
4 years, 6 months ago by fbarchard1
Modified:
4 years, 6 months ago
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Remove ifdefs for neon in row_neon*.cc ifdefs on a function level are not needed for neon functions, unless they are conditionally enabled in row.h. No functions are conditionally enabled at this time, so all ifdefs can be removed from row_neon.cc and row_neon64.cc TBR=kjellander@chromium.org BUG=libyuv:599 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/17e8a4d3dfea54489330d3a5b58817365cedb2c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -165 lines) Patch
M source/row_neon.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M source/row_neon64.cc View 91 chunks +0 lines, -162 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
fbarchard1
4 years, 6 months ago (2016-06-07 18:47:46 UTC) #1
fbarchard1
Committed patchset #1 (id:1) manually as 17e8a4d3dfea54489330d3a5b58817365cedb2c1 (presubmit successful).
4 years, 6 months ago (2016-06-07 21:34:17 UTC) #4
kjellander_chromium
4 years, 6 months ago (2016-06-08 08:11:43 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698