Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 2044213002: [Sync] Remove NOTREACHED that causes flakes in Android tests. (Closed)

Created:
4 years, 6 months ago by maxbogue
Modified:
4 years, 6 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Remove NOTREACHED that causes flakes in Android tests. It doesn't seem to actually need to be there. The comment even says that branch can happen and doesn't seem to mention it being a problem. Specifically, I have seen this cause SyncTest.testRename to flake locally. BUG=588050, 595893 Committed: https://crrev.com/682616a7c7f35634fa694a188ea0b5e97a5e8d8d Cr-Commit-Position: refs/heads/master@{#398355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M components/browser_sync/browser/profile_sync_service.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
maxbogue
Pavel, PTAL. We talked about this a long time ago but I must have forgotten ...
4 years, 6 months ago (2016-06-07 18:00:14 UTC) #2
pavely
lgtm
4 years, 6 months ago (2016-06-07 18:03:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044213002/1
4 years, 6 months ago (2016-06-07 18:15:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 18:55:44 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 18:58:22 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/682616a7c7f35634fa694a188ea0b5e97a5e8d8d
Cr-Commit-Position: refs/heads/master@{#398355}

Powered by Google App Engine
This is Rietveld 408576698