Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2044203003: VEA Test: revert timestamp test (Closed)

Created:
4 years, 6 months ago by shenghao
Modified:
4 years, 6 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VEA Test: revert timestamp test Reverting timestamp unit test in VEA would make the broken VEA tests pass. I will fix the test in another CL. BUG=614925 TEST=VEA tests pass Committed: https://crrev.com/02baad155bcc05e6bac4034aa7897408dbee5260 Cr-Commit-Position: refs/heads/master@{#398521}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M media/gpu/video_encode_accelerator_unittest.cc View 3 chunks +0 lines, -8 lines 3 comments Download

Messages

Total messages: 12 (6 generated)
shenghao
4 years, 6 months ago (2016-06-08 10:27:36 UTC) #3
Pawel Osciak
lgtm
4 years, 6 months ago (2016-06-08 10:38:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044203003/1
4 years, 6 months ago (2016-06-08 10:38:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 11:53:18 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/02baad155bcc05e6bac4034aa7897408dbee5260 Cr-Commit-Position: refs/heads/master@{#398521}
4 years, 6 months ago (2016-06-08 11:54:28 UTC) #10
wuchengli
4 years, 6 months ago (2016-06-15 08:59:21 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/2044203003/diff/1/media/gpu/video_encode_acce...
File media/gpu/video_encode_accelerator_unittest.cc (left):

https://codereview.chromium.org/2044203003/diff/1/media/gpu/video_encode_acce...
media/gpu/video_encode_accelerator_unittest.cc:1240: ASSERT_EQ(timestamp,
frame_timestamps_.front());
Use EXPECT so the rest of this function can be run. We need to run the rest when
the timestamp is wrong.

EXPECT_FALSE(frame_timestamps_.empty());
if (!frame_timestamps_.empty()) {
  EXPECT_EQ(timestamp, frame_timestamps_.front());
  frame_timestamps_.pop();
}

https://codereview.chromium.org/2044203003/diff/1/media/gpu/video_encode_acce...
media/gpu/video_encode_accelerator_unittest.cc:1241: frame_timestamps_.pop();
One input buffer can generate more than one output buffers.

Say there are three input buffers -- 0, 0.033ms, 0.066ms. It generates four
output buffers. Both cases should pass: (1) 0, 0, 0.033, 0.066 and (2) 0, 0.033,
0.033, 0.066. But 0, 0.066, 0.033, 0.066 should fail.

https://codereview.chromium.org/2044203003/diff/1/media/gpu/video_encode_acce...
File media/gpu/video_encode_accelerator_unittest.cc (right):

https://codereview.chromium.org/2044203003/diff/1/media/gpu/video_encode_acce...
media/gpu/video_encode_accelerator_unittest.cc:1320: next_input_id_ *
base::Time::kMillisecondsPerSecond /
Better to use (next_input_id_ + 1) so the timestamp is not 0. By default,
timestamp is 0 and we won't catch if the first timestamp is wrong.

Powered by Google App Engine
This is Rietveld 408576698