Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: extensions/renderer/resources/serial_service.js

Issue 2044183004: Debugging for https://crbug.com/601435. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/resources/keep_alive.js ('k') | mojo/edk/js/handle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/resources/serial_service.js
diff --git a/extensions/renderer/resources/serial_service.js b/extensions/renderer/resources/serial_service.js
index 26b990b227e60d56c43385aa0e5ac39da21a5ee0..a8a082fa2b2f20afad1393dfd2904efd1b40741a 100644
--- a/extensions/renderer/resources/serial_service.js
+++ b/extensions/renderer/resources/serial_service.js
@@ -285,7 +285,15 @@ define('serial_service', [
});
};
+ var calls = 0;
Connection.prototype.getControlSignals = function() {
+ // Creating this on any earlier call causes the handles to be lost and not
+ // cleaned up.
+ if (calls++ == 7) {
+ var pipe = core.createMessagePipe();
+ core.close(pipe.handle1);
+ core.close(pipe.handle0);
+ }
return this.remoteConnection_.getControlSignals().then(function(result) {
if (!result.signals)
throw new Error('Failed to get control signals.');
« no previous file with comments | « extensions/renderer/resources/keep_alive.js ('k') | mojo/edk/js/handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698