Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: extensions/renderer/api/serial/serial_api_unittest.cc

Issue 2044183004: Debugging for https://crbug.com/601435. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/sanitizers/lsan_suppressions.cc ('k') | extensions/renderer/resources/keep_alive.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api/serial/serial_api_unittest.cc
diff --git a/extensions/renderer/api/serial/serial_api_unittest.cc b/extensions/renderer/api/serial/serial_api_unittest.cc
index 8f745ec4ea0f287e0865c5418b9ba76280e916a9..ab6417a1056602d051c22edc6980731dd735ead0 100644
--- a/extensions/renderer/api/serial/serial_api_unittest.cc
+++ b/extensions/renderer/api/serial/serial_api_unittest.cc
@@ -488,13 +488,7 @@ TEST_F(SerialApiTest, GetConnections) {
RunTest("serial_unittest.js", "testGetConnections");
}
-// https://crbug.com/599898
-#if defined(LEAK_SANITIZER)
-#define MAYBE_GetControlSignals DISABLED_GetControlSignals
-#else
-#define MAYBE_GetControlSignals GetControlSignals
-#endif
-TEST_F(SerialApiTest, MAYBE_GetControlSignals) {
+TEST_F(SerialApiTest, GetControlSignals) {
io_handler_ = new GetControlSignalsTestIoHandler;
RunTest("serial_unittest.js", "testGetControlSignals");
EXPECT_EQ(16u, io_handler_->num_calls());
@@ -506,25 +500,13 @@ TEST_F(SerialApiTest, SetControlSignals) {
EXPECT_EQ(9u, io_handler_->num_calls());
}
-// https://crbug.com/599898
-#if defined(LEAK_SANITIZER)
-#define MAYBE_Update DISABLED_Update
-#else
-#define MAYBE_Update Update
-#endif
-TEST_F(SerialApiTest, MAYBE_Update) {
+TEST_F(SerialApiTest, Update) {
io_handler_ = new ConfigurePortTestIoHandler;
RunTest("serial_unittest.js", "testUpdate");
EXPECT_EQ(11u, io_handler_->num_calls());
}
-// https://crbug.com/599898
-#if defined(LEAK_SANITIZER)
-#define MAYBE_UpdateAcrossSerialization DISABLED_UpdateAcrossSerialization
-#else
-#define MAYBE_UpdateAcrossSerialization UpdateAcrossSerialization
-#endif
-TEST_F(SerialApiTest, MAYBE_UpdateAcrossSerialization) {
+TEST_F(SerialApiTest, UpdateAcrossSerialization) {
io_handler_ = new ConfigurePortTestIoHandler;
RunTest("serial_unittest.js", "testUpdateAcrossSerialization");
EXPECT_EQ(11u, io_handler_->num_calls());
@@ -719,13 +701,7 @@ TEST_F(SerialApiTest, DISABLED_StashAndRestoreDuringEchoError) {
new_api_test_env.RunTest("serial_unittest.js", "testRestoreAndReceiveError");
}
-// https://crbug.com/599898
-#if defined(LEAK_SANITIZER)
-#define MAYBE_StashAndRestoreNoConnections DISABLED_StashAndRestoreNoConnections
-#else
-#define MAYBE_StashAndRestoreNoConnections StashAndRestoreNoConnections
-#endif
-TEST_F(SerialApiTest, MAYBE_StashAndRestoreNoConnections) {
+TEST_F(SerialApiTest, StashAndRestoreNoConnections) {
ASSERT_NO_FATAL_FAILURE(
RunTest("serial_unittest.js", "testStashNoConnections"));
io_handler_ = nullptr;
« no previous file with comments | « build/sanitizers/lsan_suppressions.cc ('k') | extensions/renderer/resources/keep_alive.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698