Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 6 months ago by nickie Modified:
4 years, 6 months ago Reviewers:
titzer CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionAdd missing 'override' in AsmWasmBuilderImpl methods
BUG=
Committed: https://crrev.com/a9c233280430befb595a78b9754d226e02c10dc4
Cr-Commit-Position: refs/heads/master@{#36814}
Patch Set 1 #
Created: 4 years, 6 months ago
Messages
Total messages: 16 (9 generated)
The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run
The CQ bit was unchecked by nikolaos@chromium.org
The CQ bit was checked by nikolaos@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044173002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Add missing 'override' in AsmWasmBuilderImpl methods BUG= ========== to ========== Add missing 'override' in AsmWasmBuilderImpl methods BUG= ==========
nikolaos@chromium.org changed reviewers: + titzer@chromium.org
AsmWasmBuilderImpl overrides the methods of AstVisitor. I'm not sure why this compiles without the "override" keyword. I noticed when I tried replacing "final" with "override" in line https://cs.chromium.org/chromium/src/v8/src/ast/ast.h?rcl=0&l=2957 and this was the only file that produced errors.
lgtm
The CQ bit was checked by nikolaos@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044173002/1
Message was sent while issue was closed.
Description was changed from ========== Add missing 'override' in AsmWasmBuilderImpl methods BUG= ========== to ========== Add missing 'override' in AsmWasmBuilderImpl methods BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add missing 'override' in AsmWasmBuilderImpl methods BUG= ========== to ========== Add missing 'override' in AsmWasmBuilderImpl methods BUG= Committed: https://crrev.com/a9c233280430befb595a78b9754d226e02c10dc4 Cr-Commit-Position: refs/heads/master@{#36814} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a9c233280430befb595a78b9754d226e02c10dc4 Cr-Commit-Position: refs/heads/master@{#36814} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
