Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2044173002: Add missing 'override' in AsmWasmBuilderImpl methods (Closed)

Created:
4 years, 6 months ago by nickie
Modified:
4 years, 6 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add missing 'override' in AsmWasmBuilderImpl methods BUG= Committed: https://crrev.com/a9c233280430befb595a78b9754d226e02c10dc4 Cr-Commit-Position: refs/heads/master@{#36814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -52 lines) Patch
M src/wasm/asm-wasm-builder.cc View 27 chunks +65 lines, -52 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044173002/1
4 years, 6 months ago (2016-06-07 16:20:13 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 17:01:40 UTC) #6
nickie
AsmWasmBuilderImpl overrides the methods of AstVisitor. I'm not sure why this compiles without the "override" ...
4 years, 6 months ago (2016-06-07 17:15:10 UTC) #9
titzer
lgtm
4 years, 6 months ago (2016-06-08 05:34:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044173002/1
4 years, 6 months ago (2016-06-08 08:07:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 08:09:39 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 08:11:19 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9c233280430befb595a78b9754d226e02c10dc4
Cr-Commit-Position: refs/heads/master@{#36814}

Powered by Google App Engine
This is Rietveld 408576698