third_party/WebKit/Source/core/paint/FilterEffectBuilder.h - Issue 2044153002: Move ReferenceFilterBuilder::build to FilterEffectBuilder

Unified Diff: third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

Issue 2044153002: Move ReferenceFilterBuilder::build to FilterEffectBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@filter-remove-reffilter-vector-feb

Patch Set: Workaround empty filterRegion discrepancy. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp ('k') | third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp » ('j') | third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

diff --git a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

index 443a22c738fd37712e5c4019b82319c25aa8018b..d923bb38aa5008d45886074b3c88c0f409787712 100644

--- a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

+++ b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

@@ -34,8 +34,11 @@ class SkPaint;

namespace blink {

-class FilterOperations;

class Element;

+class FilterOperations;

+class ReferenceFilterOperation;

+class SVGFilterElement;

+class SVGFilterGraphNodeMap;

class CORE_EXPORT FilterEffectBuilder final : public GarbageCollectedFinalized<FilterEffectBuilder> {

public:

@@ -47,6 +50,9 @@ public:

virtual ~FilterEffectBuilder();

DECLARE_TRACE();

+ static Filter* buildReferenceFilter(const ReferenceFilterOperation&, const FloatSize* referenceBoxSize, const SkPaint* fillPaint, const SkPaint* strokePaint, Element&, FilterEffect* previousEffect, float zoom);

+ static Filter* buildReferenceFilter(SVGFilterElement&, const FloatRect& referenceBox, const SkPaint* fillPaint, const SkPaint* strokePaint, FilterEffect* previousEffect, float zoom, SVGFilterGraphNodeMap* = nullptr);

pdr. 2016/06/08 23:12:50 The first buildReferenceFilter wants a zoomed refe

fs 2016/06/09 08:33:07 Yes, I think renaming is reasonable. In time I thi

bool build(Element*, const FilterOperations&, float zoom, const FloatSize* referenceBoxSize = nullptr, const SkPaint* fillPaint = nullptr, const SkPaint* strokePaint = nullptr);

FilterEffect* lastEffect() const