ui/views/accessibility/ax_window_obj_wrapper.cc - Issue 2044123003: Fix crash when closing a window with an associated widget child

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/accessibility/ax_window_obj_wrapper.cc

Issue 2044123003: Fix crash when closing a window with an associated widget child (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/accessibility/ax_window_obj_wrapper.cc

diff --git a/ui/views/accessibility/ax_window_obj_wrapper.cc b/ui/views/accessibility/ax_window_obj_wrapper.cc

index c96457318e0930101f54e045b8de0fc7ccd69b7d..5b6f226ea3502110de491648e2d188d063951e14 100644

--- a/ui/views/accessibility/ax_window_obj_wrapper.cc

+++ b/ui/views/accessibility/ax_window_obj_wrapper.cc

@@ -43,7 +43,7 @@ void AXWindowObjWrapper::GetChildren(

// Also consider any associated widgets as children.

Widget* widget = Widget::GetWidgetForNativeView(window_);

- if (widget)

+ if (widget && widget->IsVisible())

out_children->push_back(AXAuraObjCache::GetInstance()->GetOrCreate(widget));

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »