Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 2044113002: Turn Function.prototype.bind into a hydrogen stub optimized for the common case (Closed)

Created:
4 years, 6 months ago by Toon Verwaest
Modified:
4 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn Function.prototype.bind into a hydrogen stub optimized for the common case This speeds up .bind by >10x as measured by function f(a,b,c) {} for (var i = 0; i < 10000000; i++) { f.bind(1); // or more arguments. } (Uses hydrogen-stubs rather than TF due to var-args + possible runtime fallback, which is still unsupported in TF.) BUG= Committed: https://crrev.com/520a214b889ea9fd09883b20d6b7feaa20f55a92 Cr-Commit-Position: refs/heads/master@{#36817}

Patch Set 1 #

Patch Set 2 : Ports #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : arm64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -21 lines) Patch
M src/arm/code-stubs-arm.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 4 chunks +18 lines, -5 lines 0 comments Download
M src/builtins.cc View 1 2 2 chunks +19 lines, -2 lines 0 comments Download
M src/code-stubs.h View 1 2 chunks +10 lines, -1 line 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +185 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 3 chunks +16 lines, -0 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M src/deoptimizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/interface-descriptors.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/interface-descriptors.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x87/code-stubs-x87.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
Toon Verwaest
ptal
4 years, 6 months ago (2016-06-07 14:42:01 UTC) #2
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/2044113002/diff/20001/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/2044113002/diff/20001/src/builtins.cc#newcode4334 src/builtins.cc:4334: // can Please fix comment ...
4 years, 6 months ago (2016-06-07 16:24:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044113002/40001
4 years, 6 months ago (2016-06-08 08:51:27 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/2770)
4 years, 6 months ago (2016-06-08 08:57:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044113002/60001
4 years, 6 months ago (2016-06-08 09:22:11 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-08 09:44:33 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 09:46:25 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/520a214b889ea9fd09883b20d6b7feaa20f55a92
Cr-Commit-Position: refs/heads/master@{#36817}

Powered by Google App Engine
This is Rietveld 408576698