third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h - Issue 2044093002: Blink image-decoders: (lazy) deferred image decoding support for ICO

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h

Issue 2044093002: Blink image-decoders: (lazy) deferred image decoding support for ICO (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h

diff --git a/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h b/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h

index 3df9ba16767fa8a2e25c669b9e4a09cb28d0faf2..7bfe240a00d5498ee9b815067c6fe99eafc3eec3 100644

--- a/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h

+++ b/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h

@@ -50,6 +50,7 @@ public:

IntSize size() const override;

IntSize frameSizeAtIndex(size_t) const override;

bool setSize(unsigned width, unsigned height) override;

+ bool frameIsCompleteAtIndex(size_t) const override;

// CAUTION: setFailed() deletes all readers and decoders. Be careful to

// avoid accessing deleted memory, especially when calling this from

// inside BMPImageReader!

@@ -74,6 +75,7 @@ private:

uint16_t m_bitCount;

IntPoint m_hotSpot;

uint32_t m_imageOffset;

+ uint32_t m_byteSize;

};

// Returns true if |a| is a preferable icon entry to |b|.