Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2044063002: [compiler] Improve contract for Compiler::CompileDebugCode. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
neis, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Improve contract for Compiler::CompileDebugCode. This changes the contract for the aforementioned API function to be more permissive and allow callers to call it with less restrictions. The new contract is: a) For so far un-compiled functions, the compiler is free to choose the backend according to other decision criteria. Debug code can hence be provided by either Ignition or FullCodegen. b) For compiled functions, the compiler will provide debug code within the same tier as existing code. For Ignition the generated code will be equivalent to the old one. For FullCodegen the code will contain debug information and debug break slots. Concretely this fixes an issue where generator or async functions might have been compiled with an unexpected backend, due to the fact that the API method in question was always providing FullCodegen code. R=yangguo@chromium.org Committed: https://crrev.com/80b98da2cda6d0225798cec4213d842811d20df3 Cr-Commit-Position: refs/heads/master@{#36808}

Patch Set 1 #

Patch Set 2 : Fix comment. #

Patch Set 3 : Incorporate patch from Yang Guo. #

Patch Set 4 : Workaround for regenerated bytecode. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M src/compiler.cc View 1 2 3 2 chunks +15 lines, -1 line 0 comments Download
M src/debug/liveedit.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/debug/liveedit.cc View 1 2 4 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael Starzinger
Yang: PTAL. Georg: FYI.
4 years, 6 months ago (2016-06-07 14:19:10 UTC) #4
Yang
lgtm!
4 years, 6 months ago (2016-06-08 07:00:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044063002/60001
4 years, 6 months ago (2016-06-08 07:05:44 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-08 07:07:29 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 07:08:33 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/80b98da2cda6d0225798cec4213d842811d20df3
Cr-Commit-Position: refs/heads/master@{#36808}

Powered by Google App Engine
This is Rietveld 408576698