Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2044023005: Make PropertyReference value() return a const CSSValue& (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_remove_style_property_set_mutable_overload
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Element.cpp
diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp
index fc38c794e94278e4516a9883ffa4d8068317b190..c3faafd5b894f3f8dc9e509a2b3297767decadcf 100644
--- a/third_party/WebKit/Source/core/dom/Element.cpp
+++ b/third_party/WebKit/Source/core/dom/Element.cpp
@@ -3265,7 +3265,7 @@ static bool needsURLResolutionForInlineStyle(const Element& element, const Docum
return false;
for (unsigned i = 0; i < style->propertyCount(); ++i) {
// FIXME: Should handle all URL-based properties: CSSImageSetValue, CSSCursorImageValue, etc.
- if (style->propertyAt(i).value()->isImageValue())
+ if (style->propertyAt(i).value().isImageValue())
return true;
}
return false;
@@ -3276,8 +3276,8 @@ static void reResolveURLsInInlineStyle(const Document& document, MutableStylePro
for (unsigned i = 0; i < style.propertyCount(); ++i) {
StylePropertySet::PropertyReference property = style.propertyAt(i);
// FIXME: Should handle all URL-based properties: CSSImageSetValue, CSSCursorImageValue, etc.
- if (property.value()->isImageValue())
- toCSSImageValue(property.value())->reResolveURL(document);
+ if (property.value().isImageValue())
+ toCSSImageValue(property.value()).reResolveURL(document);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp ('k') | third_party/WebKit/Source/core/editing/EditingStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698