Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: base/task_scheduler/scheduler_worker_thread_stack_unittest.cc

Issue 2044023003: Virtualize The Existence of a Scheduler Worker Thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@detach
Patch Set: CR Feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_worker_thread_stack_unittest.cc
diff --git a/base/task_scheduler/scheduler_worker_thread_stack_unittest.cc b/base/task_scheduler/scheduler_worker_thread_stack_unittest.cc
index 629b77952249c5cbb5bde78cd788e2bc18c2f877..641665beea3d267705c23b273e360ac58e2d78e8 100644
--- a/base/task_scheduler/scheduler_worker_thread_stack_unittest.cc
+++ b/base/task_scheduler/scheduler_worker_thread_stack_unittest.cc
@@ -32,10 +32,11 @@ class MockSchedulerWorkerThreadDelegate
ADD_FAILURE() << "This delegate not expect to have sequences to reenqueue.";
}
TimeDelta GetSleepTimeout() override {
- ADD_FAILURE() <<
- "The mock thread is not expected to be woken before it is shutdown";
return TimeDelta::Max();
}
+ bool CanDetach(SchedulerWorkerThread* worker_thread) override {
+ return false;
+ }
};
class TaskSchedulerWorkerThreadStackTest : public testing::Test {
@@ -43,15 +44,18 @@ class TaskSchedulerWorkerThreadStackTest : public testing::Test {
void SetUp() override {
thread_a_ = SchedulerWorkerThread::Create(
ThreadPriority::NORMAL,
- WrapUnique(new MockSchedulerWorkerThreadDelegate), &task_tracker_);
+ WrapUnique(new MockSchedulerWorkerThreadDelegate), &task_tracker_,
+ SchedulerWorkerThread::InitialWorkerState::ALIVE);
ASSERT_TRUE(thread_a_);
thread_b_ = SchedulerWorkerThread::Create(
ThreadPriority::NORMAL,
- WrapUnique(new MockSchedulerWorkerThreadDelegate), &task_tracker_);
+ WrapUnique(new MockSchedulerWorkerThreadDelegate), &task_tracker_,
+ SchedulerWorkerThread::InitialWorkerState::ALIVE);
ASSERT_TRUE(thread_b_);
thread_c_ = SchedulerWorkerThread::Create(
ThreadPriority::NORMAL,
- WrapUnique(new MockSchedulerWorkerThreadDelegate), &task_tracker_);
+ WrapUnique(new MockSchedulerWorkerThreadDelegate), &task_tracker_,
+ SchedulerWorkerThread::InitialWorkerState::ALIVE);
ASSERT_TRUE(thread_c_);
}

Powered by Google App Engine
This is Rietveld 408576698