Maintain wrapper tracing deque in ScriptWrappableVisitor

Maintain wrapper tracing deque in ScriptWrappableVisitor

This cl uses updated V8 api which will be easier to work with incrementally
(althrough it is not used incrementally at the moment). For that
ScriptWrappableVisitor now has to maintain his marking deque.

LOG=no
BUG=468240
Committed: https://crrev.com/ea056bf4f3cf4068be204112ed5171147861c6f9
Cr-Commit-Position: refs/heads/master@{#398273}

[Marcel Hlopko, 2016-06-07 08:09:56]

hlopko@chromium.org changed reviewers:
+ haraken@chromium.org, hpayer@chromium.org, jochen@chromium.org

[Marcel Hlopko, 2016-06-07 08:53:43]

Ptal.

[haraken, 2016-06-07 09:06:48]

LGTM

https://codereview.chromium.org/2044023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp
(right):

https://codereview.chromium.org/2044023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp:62: ||
WTF::monotonicallyIncreasingTimeMS() < deadlineInMs) {

This is okay in this CL but we should avoid calling
WTF::monotonicallyIncreasingTimeMS at each tracing.
WTF::monotonicallyIncreasingTimeMS is heavy.

https://codereview.chromium.org/2044023002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h
(right):

https://codereview.chromium.org/2044023002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h:79: mutable
WTF::Deque<const ScriptWrappable*> m_markingDeque;

Add a comment why it's safe to store raw pointers to those ScriptWrappables.

[Marcel Hlopko, 2016-06-07 09:24:51]

The CQ bit was checked by hlopko@chromium.org

[Marcel Hlopko, 2016-06-07 09:24:51]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2044023002/#ps40001
(title: "Add comments")

[commit-bot: I haz the power, 2016-06-07 09:25:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044023002/40001

[commit-bot: I haz the power, 2016-06-07 11:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 11:12:52]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Marcel Hlopko, 2016-06-07 11:13:37]

The CQ bit was checked by hlopko@chromium.org

[commit-bot: I haz the power, 2016-06-07 11:13:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044023002/40001

[commit-bot: I haz the power, 2016-06-07 12:02:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-07 12:04:47]

Description was changed from

==========
Maintain wrapper tracing deque in ScriptWrappableVisitor

This cl uses updated V8 api which will be easier to work with incrementally
(althrough it is not used incrementally at the moment). For that
ScriptWrappableVisitor now has to maintain his marking deque.

LOG=no
BUG=468240
==========

to

==========
Maintain wrapper tracing deque in ScriptWrappableVisitor

This cl uses updated V8 api which will be easier to work with incrementally
(althrough it is not used incrementally at the moment). For that
ScriptWrappableVisitor now has to maintain his marking deque.

LOG=no
BUG=468240

Committed: https://crrev.com/ea056bf4f3cf4068be204112ed5171147861c6f9
Cr-Commit-Position: refs/heads/master@{#398273}
==========

[commit-bot: I haz the power, 2016-06-07 12:04:47]

Patchset 3 (id:??) landed as
https://crrev.com/ea056bf4f3cf4068be204112ed5171147861c6f9
Cr-Commit-Position: refs/heads/master@{#398273}

[Michael Achenbach, 2016-06-07 12:32:02]

machenbach@chromium.org changed reviewers:
+ machenbach@chromium.org

[Michael Achenbach, 2016-06-07 12:32:03]

API backwards-compatibility nag:
https://build.chromium.org/p/chromium.fyi/builders/Linux%20V8%20API%20Stabili...