Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Issue 2044013002: [build] Landmine after ndk update. (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Landmine after ndk update. Bots broke after https://codereview.chromium.org/2040913002/ BUG=chromium:599327 NOTRY=true NOPRESUBMIT=true TBR=bmeurer@chromium.org Committed: https://crrev.com/688ae587272b4f489210c5f593539983624375b9 Cr-Commit-Position: refs/heads/master@{#36771}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gypfiles/get_landmines.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044013002/1
4 years, 6 months ago (2016-06-07 06:29:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16611)
4 years, 6 months ago (2016-06-07 06:32:29 UTC) #7
Michael Achenbach
This should bot be necessary. It looks like the logic that rebuilds everything after ndk ...
4 years, 6 months ago (2016-06-07 06:40:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044013002/1
4 years, 6 months ago (2016-06-07 06:40:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 06:41:14 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 06:41:49 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/688ae587272b4f489210c5f593539983624375b9
Cr-Commit-Position: refs/heads/master@{#36771}

Powered by Google App Engine
This is Rietveld 408576698