Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2044003004: [stubs] Fix flaky failures of cctest/test-code-stub-assembler/SeededNumberDictionaryLookup. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fix flaky failures of cctest/test-code-stub-assembler/SeededNumberDictionaryLookup. Dictionary::Add() must not be called for existing keys. Committed: https://crrev.com/7ba12573e07b52c61587de39cf1dd4690d4a5e99 Cr-Commit-Position: refs/heads/master@{#36792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/cctest/test-code-stub-assembler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044003004/1
4 years, 6 months ago (2016-06-07 14:17:26 UTC) #2
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-07 14:31:26 UTC) #5
Jakob Kummerow
lgtm
4 years, 6 months ago (2016-06-07 14:39:39 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 14:44:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044003004/1
4 years, 6 months ago (2016-06-07 14:44:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 14:46:48 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 14:49:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ba12573e07b52c61587de39cf1dd4690d4a5e99
Cr-Commit-Position: refs/heads/master@{#36792}

Powered by Google App Engine
This is Rietveld 408576698