Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2044003003: [runtime] Don't use ElementsTransitionAndStoreStub for transitions that involve instance rewriting. (Closed)

Created:
4 years, 6 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Don't use ElementsTransitionAndStoreStub for transitions that involve instance rewriting. BUG=chromium:617524, v8:5009 LOG=Y Committed: https://crrev.com/3e0be8d7fca5b28bcb18ae413be6392325d0b54c Cr-Commit-Position: refs/heads/master@{#36780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 2 chunks +13 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-617524.js View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044003003/1
4 years, 6 months ago (2016-06-07 09:08:01 UTC) #2
Igor Sheludko
PTAL
4 years, 6 months ago (2016-06-07 09:08:11 UTC) #4
Toon Verwaest
lgtm
4 years, 6 months ago (2016-06-07 09:11:24 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-07 09:35:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044003003/1
4 years, 6 months ago (2016-06-07 09:44:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 09:47:01 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 09:50:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e0be8d7fca5b28bcb18ae413be6392325d0b54c
Cr-Commit-Position: refs/heads/master@{#36780}

Powered by Google App Engine
This is Rietveld 408576698